-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xtensa-build-zephyr.py: add new PlatformConfig dataclass #7255
Conversation
Reduces duplication and provides more flexibility. Also switch the list of platforms to a dict. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for the flexibility. Thanks @marc-hb !
I don't know why the firmware crashed in https://sof-ci.01.org/sofpr/PR7255/build4495/devicetest/index.html?model=ADLP_RVP_NOCODEC_IPC4ZPH&testcase=multiple-pause-resume-5 but for sure it was not because of this PR. Everything else is green.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aborisovich good for Windows ?
Reduces duplication and provides more flexibility.
Also switch the list of platforms to a dict.