Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smart_amp_test: fix unbind implementation #7450

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

kv2019i
Copy link
Collaborator

@kv2019i kv2019i commented Apr 17, 2023

Code in unbind is looking at wrong field for queue-id. This works some of the time, but in some cases leads to access to freed heap data and later to heap corruption.

Link: #7191

Code in unbind is looking at wrong field for queue-id. This works
some of the time, but in some cases leads to access to freed
heap data and later to heap corruption.

Link: thesofproject#7191
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
@kv2019i
Copy link
Collaborator Author

kv2019i commented Apr 17, 2023

@ranj063 @andrula-song @RanderWang This fixes a clear error that leads to heap corruption with our nocodec topologies. I noticed we still have #7101 open (to remove unbind-bind), but that has not moved forward.

Copy link
Collaborator

@ranj063 ranj063 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch @kv2019i

@ranj063
Copy link
Collaborator

ranj063 commented Apr 17, 2023

@ranj063 @andrula-song @RanderWang This fixes a clear error that leads to heap corruption with our nocodec topologies. I noticed we still have #7101 open (to remove unbind-bind), but that has not moved forward.

@kv2019i im going to close 7101 in favor of @andrula-song 's PR to modify the smartamp to use module adapter

Copy link
Collaborator

@RanderWang RanderWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I also fixed in my PR #7259. But I forgot to submit it when closing my PR

@kv2019i
Copy link
Collaborator Author

kv2019i commented Apr 18, 2023

SOFCI TEST

@kv2019i
Copy link
Collaborator Author

kv2019i commented Apr 18, 2023

https://sof-ci.01.org/sofpr/PR7450/build5941/devicetest/index.html -> one PM fail not related to this PR
https://sof-ci.01.org/sofpr/PR7450/build5942/devicetest/index.html -> fails in multi-pipeline test, potentially case of #7361
mainline Zephyr fails -> known problem with SYS_INIT interface change

Proceeding with merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants