-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
smart_amp_test: fix unbind implementation #7450
smart_amp_test: fix unbind implementation #7450
Conversation
Code in unbind is looking at wrong field for queue-id. This works some of the time, but in some cases leads to access to freed heap data and later to heap corruption. Link: thesofproject#7191 Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
@ranj063 @andrula-song @RanderWang This fixes a clear error that leads to heap corruption with our nocodec topologies. I noticed we still have #7101 open (to remove unbind-bind), but that has not moved forward. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch @kv2019i
@kv2019i im going to close 7101 in favor of @andrula-song 's PR to modify the smartamp to use module adapter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I also fixed in my PR #7259. But I forgot to submit it when closing my PR
SOFCI TEST |
https://sof-ci.01.org/sofpr/PR7450/build5941/devicetest/index.html -> one PM fail not related to this PR Proceeding with merge. |
Code in unbind is looking at wrong field for queue-id. This works some of the time, but in some cases leads to access to freed heap data and later to heap corruption.
Link: #7191