Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio: Peak volume: Add Kconfig to select the period of reporting peak meter value. #7715

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

andrula-song
Copy link
Contributor

@andrula-song andrula-song commented May 31, 2023

Add kconfig to select the period of reporting peak meter value. The default value is reporting peak meter every 10 ms.

@andrula-song
Copy link
Contributor Author

andrula-song commented May 31, 2023

Test on mtlp-rvp-nocodec with 32bit format, here is the result.
the perf of original code is:
[00:00:54.438,273] component: comp_copy: comp:0 0x60000 perf comp_copy samples 48 period 1000 cpu avg 333 peak 343
[00:00:54.437,185] component: comp_copy: comp:1 0x60001 perf comp_copy samples 48 period 1000 cpu avg 317 peak 325

the perf of setting as updating every 5ms is :
[00:00:40.105,926] component: comp_copy: comp:0 0x60000 perf comp_copy samples 48 period 1000 cpu avg 309 peak 346
[00:00:40.104,835] component: comp_copy: comp:1 0x60001 perf comp_copy samples 48 period 1000 cpu avg 301 peak 338

the perf of setting as updating every 10ms is :
[00:00:21.674,308] component: comp_copy: comp:0 0x60000 perf comp_copy samples 48 period 1000 cpu avg 301 peak 339

[00:00:22.697,213] component: comp_copy: comp:1 0x60001 perf comp_copy samples 48 period 1000 cpu avg 297 peak 336

the perf of setting as updating every 100ms is :
[00:00:24.744,386] component: comp_copy: comp:0 0x60000 perf comp_copy samples 48 period 1000 cpu avg 301 peak 333
[00:00:25.767,296] component: comp_copy: comp:1 0x60001 perf comp_copy samples 48 period 1000 cpu avg 297 peak 345

since the result of 10ms is almost the same with 100ms, so I set the default value as 10ms to update peak meter. And in this way we can save about 9.6% cycles.

@andrula-song andrula-song requested a review from singalsu May 31, 2023 06:43
Copy link
Collaborator

@singalsu singalsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@andrula-song andrula-song marked this pull request as ready for review June 1, 2023 11:02
@andrula-song andrula-song requested review from kv2019i and removed request for dbaluta, plbossart, ranj063, lbetlej, mmaka1 and jxstelter June 1, 2023 11:02
Copy link
Contributor

@btian1 btian1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before go to merge, shall we contact windows team to test peak_vol again? since current CI does not cover peak_vol case.

@kv2019i
Copy link
Collaborator

kv2019i commented Jun 6, 2023

@btian1 wrote:

before go to merge, shall we contact windows team to test peak_vol again? since current CI does not cover peak_vol case.

This is covered in "Internal Intel CI System/merge/codecheck" tests.

peak meter value

Add kconfig to select the period of reporting peak meter value.
The default value is reporting peak meter every 10 ms.

Signed-off-by: Andrula Song <andrula.song@intel.com>
@kv2019i
Copy link
Collaborator

kv2019i commented Jun 7, 2023

#7191 is hitting in https://sof-ci.01.org/sofpr/PR7715/build9082/devicetest/index.html , but it's seen on the daily tests witout this PR. https://sof-ci.01.org/sofpr/PR7715/build9083/devicetest/index.html has only unrelated fails. I'll proceed with merge.

@kv2019i kv2019i merged commit b787bea into thesofproject:main Jun 7, 2023
@andrula-song andrula-song deleted the peakvol branch June 26, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants