-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audio: Peak volume: Add Kconfig to select the period of reporting peak meter value. #7715
Conversation
Test on mtlp-rvp-nocodec with 32bit format, here is the result. the perf of setting as updating every 5ms is : the perf of setting as updating every 10ms is : [00:00:22.697,213] component: comp_copy: comp:1 0x60001 perf comp_copy samples 48 period 1000 cpu avg 297 peak 336 the perf of setting as updating every 100ms is : since the result of 10ms is almost the same with 100ms, so I set the default value as 10ms to update peak meter. And in this way we can save about 9.6% cycles. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
before go to merge, shall we contact windows team to test peak_vol again? since current CI does not cover peak_vol case.
@btian1 wrote:
This is covered in "Internal Intel CI System/merge/codecheck" tests. |
peak meter value Add kconfig to select the period of reporting peak meter value. The default value is reporting peak meter every 10 ms. Signed-off-by: Andrula Song <andrula.song@intel.com>
#7191 is hitting in https://sof-ci.01.org/sofpr/PR7715/build9082/devicetest/index.html , but it's seen on the daily tests witout this PR. https://sof-ci.01.org/sofpr/PR7715/build9083/devicetest/index.html has only unrelated fails. I'll proceed with merge. |
Add kconfig to select the period of reporting peak meter value. The default value is reporting peak meter every 10 ms.