Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rimage: mtl: add copier and eq-iir CPC cases #8660

Merged
merged 1 commit into from
Dec 22, 2023
Merged

rimage: mtl: add copier and eq-iir CPC cases #8660

merged 1 commit into from
Dec 22, 2023

Conversation

btian1
Copy link
Contributor

@btian1 btian1 commented Dec 21, 2023

Copier missed ibs(384)/obs(192) case, and eq-iir missed ibs(384)/obs(384) case, adding it to current CPC config.

@btian1 btian1 marked this pull request as ready for review December 21, 2023 02:05
@btian1 btian1 mentioned this pull request Dec 21, 2023
Merged
kv2019i
kv2019i approved these changes Dec 21, 2023
View reviewed changes
Copy link
Collaborator

@kv2019i kv2019i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @btian1 for fast update! Can you fix the commit prefix to "rimage: mtl: add copier and eq-iir CPC cases"

This will be racing with #8490 , one needs to be udpated after another, FYI @lyakh

kv2019i
kv2019i requested changes Dec 21, 2023
View reviewed changes
Copy link
Collaborator

@kv2019i kv2019i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong button, adding request changes to fix the git commit.

@lgirdwood
Copy link
Member

Thank you @btian1 for fast update! Can you fix the commit prefix to "rimage: mtl: add copier and eq-iir CPC cases"

This will be racing with #8490 , one needs to be udpated after another, FYI @lyakh

@btian1 fyi TOML PR now merged

@btian1 btian1 changed the title Audio: CPC: add missed CPC config for copier and eq-iir rimage: mtl: add copier and eq-iir CPC cases Dec 22, 2023
@btian1
rimage: mtl: add copier and eq-iir CPC cases
9a0f4d8 
Copier missed ibs(384)/obs(192) case, and eq-iir missed
ibs(384)/obs(384) case, adding it to current CPC config for mtl.

Signed-off-by: Baofeng Tian <baofeng.tian@intel.com>
@btian1 btian1 requested a review from kv2019i December 22, 2023 07:45
singalsu
singalsu approved these changes Dec 22, 2023
View reviewed changes
Copy link
Collaborator

@singalsu singalsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I can't decode the numbers in my head but looks assuring. Yep I know you got the numbers from tool so they are right :)

kv2019i
kv2019i approved these changes Dec 22, 2023
View reviewed changes
Copy link
Collaborator

@kv2019i kv2019i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kv2019i kv2019i merged commit b617388 into thesofproject:main Dec 22, 2023
43 of 44 checks passed
@btian1 btian1 mentioned this pull request Dec 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kv2019i kv2019i kv2019i approved these changes

@singalsu singalsu singalsu approved these changes

@lgirdwood lgirdwood Awaiting requested review from lgirdwood

@plbossart plbossart Awaiting requested review from plbossart

@mmaka1 mmaka1 Awaiting requested review from mmaka1

@lbetlej lbetlej Awaiting requested review from lbetlej

@dbaluta dbaluta Awaiting requested review from dbaluta

@RanderWang RanderWang Awaiting requested review from RanderWang RanderWang is a code owner

@abonislawski abonislawski Awaiting requested review from abonislawski abonislawski is a code owner

@pblaszko pblaszko Awaiting requested review from pblaszko pblaszko is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@btian1 @lgirdwood @singalsu @kv2019i