Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SKIP SOF-TEST] fuzz.sh: add -jobs parameter. Switch to built-in -max_total_time. #8851

Merged
merged 3 commits into from
Feb 29, 2024

Conversation

marc-hb
Copy link
Collaborator

@marc-hb marc-hb commented Feb 10, 2024

There was no need to use the external "timeout" command + some complicated exit code logic, libFuzzer has that feature built-in. Switch to it and delete a few good line.

Add an option to use the built-in, concurrent -jobs feature which saves a massive amount of time. It has some quirks so do not enable it by default.

Decrease verbosity by default.

Add in the help message the magic replay command that saves a ton of time.

cc:

@marc-hb
Copy link
Collaborator Author

marc-hb commented Feb 10, 2024

@marc-hb marc-hb marked this pull request as ready for review February 10, 2024 01:23
@marc-hb marc-hb requested a review from dbaluta as a code owner February 12, 2024 08:21
@marc-hb
Copy link
Collaborator Author

marc-hb commented Feb 12, 2024

Brand new failure in https://github.com/thesofproject/sof/actions/runs/7868973600/job/21467150473?pr=8851? Demoting to draft for now.

@marc-hb marc-hb marked this pull request as draft February 12, 2024 08:36
@cujomalainey
Copy link
Contributor

Brand new failure in https://github.com/thesofproject/sof/actions/runs/7868973600/job/21467150473?pr=8851? Demoting to draft for now.

@andyross is that another panic being masked?

There was no need to use the external "timeout" command + some
complicated exit code logic, libFuzzer has that feature built-in. Switch
to it and delete a few good line.

Add an option to use the built-in, concurrent -jobs feature which saves
a massive amount of time. It has some quirks so do not enable it by
default.

Decrease verbosity by default.

Add in the help message the magic replay command that saves a ton of time.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Use new option to fuzz more in the same time.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
@marc-hb marc-hb marked this pull request as ready for review February 27, 2024 17:46
@marc-hb
Copy link
Collaborator Author

marc-hb commented Feb 27, 2024

@andyross is that another panic being masked?

No I think it was just the original #8832 that was not fixed yet at the time and very poorly reported.

Reporting fixed in brand new #8886 just submitted, please review. Magnificient stack trace there!

Promoting this -j PR back to "ready" too.

"Unit test" crash-* files allow instant reproduction.

fuzz-*.log files are created when using -j

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
@lgirdwood
Copy link
Member

@marc-hb are all the dependencies in the PR message now met ?

@marc-hb
Copy link
Collaborator Author

marc-hb commented Feb 28, 2024

I did submit more than one PR to make debugging fuzzing issues significantly easier and faster but they are all independent of each other and can be merged in any order. This can be merged.

When there are dependencies between commits I either put them in the same PR or if too big then I hold back depending PRs as drafts.

@lgirdwood lgirdwood merged commit dfc59bc into thesofproject:main Feb 29, 2024
38 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants