Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DNM] dai: add support for Intel UAOL DAI #9227
base: main
Are you sure you want to change the base?
[DNM] dai: add support for Intel UAOL DAI #9227
Changes from all commits
3b12ef7
0ba3ac2
2613355
d3c99ca
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't fully understand this.
for LNL+ all the DMA stuff is handled in the same way with an HDaudio-based solution.
We just moved some of the ALH stuff into the HDaudio prodessing - see line 94 the test for ALH.
so shouldn't the UAOL stuff also be moved under the HDAudio category? Why special case what looks identical?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my comment still stands.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tlissows any update here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed support for MTL, so the line is no longer present.
However the concept of handling UAOL by HDA code (and removing of all UAOL related stuff from SOF) seems not to be applicable. This is because of UAOL being a type of DAI handled by separate Zephyr driver with the specific API.