Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

west.ytml: update to Zephyr 650227d8c47f (July 3rd) #9278

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

kv2019i
Copy link
Collaborator

@kv2019i kv2019i commented Jul 3, 2024

Update Zephyr baseline to 650227d8c47f

Change affecting SOF build targets:

32d05d360b93 intel_adsp/ace: power: fix firmware panic on MTL
a3835041bd36 intel_adsp/ace: power: Use MMU reinit API on core context restore
a983a5e399fd dts: xtensa: intel: Remove non-existent power domains from ACE30 PTL DTS
a2eada74c663 dts: xtensa: intel: Remove ALH nodes from ACE 3.0 PTL DTS
442e697a8ff7 dts: xtensa: intel: Reorder power domains by bit position in ACE30
d1b5d7092e5a intel_adsp: ace30: Correct power control register bitfield definitions
31c96cf3957b xtensa: check stack boundaries during backtrace
5b84bb4f4a55 xtensa: check stack frame pointer before dumping registers
cb9f8b1019f1 xtensa: separate FATAL EXCEPTION printout into two
e9c23274afa2 Revert "soc: intel_adsp: only implement FW_STATUS boot protocol for cavs"
1198c7ec295b Drivers: DAI: Intel: Move ACE DMIC start reset clear to earlier
78920e839e71 Drivers: DAI: Intel: Reduce traces dai_dmic_start()
9db580357bc6 Drivers: DAI: Intel: Remove trace from dai_dmic_update_bits()
f91700e62968 linker: nxp: adsp: add orphan linker section

Also:

Update Zephyr baseline to 650227d8c47f

Change affecting SOF build targets:

32d05d360b93 intel_adsp/ace: power: fix firmware panic on MTL
a3835041bd36 intel_adsp/ace: power: Use MMU reinit API on core context restore
a983a5e399fd dts: xtensa: intel: Remove non-existent power domains from ACE30 PTL DTS
a2eada74c663 dts: xtensa: intel: Remove ALH nodes from ACE 3.0 PTL DTS
442e697a8ff7 dts: xtensa: intel: Reorder power domains by bit position in ACE30
d1b5d7092e5a intel_adsp: ace30: Correct power control register bitfield definitions
31c96cf3957b xtensa: check stack boundaries during backtrace
5b84bb4f4a55 xtensa: check stack frame pointer before dumping registers
cb9f8b1019f1 xtensa: separate FATAL EXCEPTION printout into two
e9c23274afa2 Revert "soc: intel_adsp: only implement FW_STATUS boot protocol for cavs"
1198c7ec295b Drivers: DAI: Intel: Move ACE DMIC start reset clear to earlier
78920e839e71 Drivers: DAI: Intel: Reduce traces dai_dmic_start()
9db580357bc6 Drivers: DAI: Intel: Remove trace from dai_dmic_update_bits()
f91700e62968 linker: nxp: adsp: add orphan linker section

Link: thesofproject#9268
Link: thesofproject#9243
Link: thesofproject#9205
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
@kv2019i kv2019i requested review from lyakh, marc-hb and dnikodem July 3, 2024 14:35
@kv2019i kv2019i changed the title west.ytml: update to Zephyr 650227d8c47f west.ytml: update to Zephyr 650227d8c47f (July 3rd) Jul 3, 2024
@kv2019i
Copy link
Collaborator Author

kv2019i commented Jul 3, 2024

@andyross @marc-hb So now fuzzer fails? Seems to segfault immediately in Printf()...?

@andyross
Copy link
Contributor

andyross commented Jul 3, 2024

Odd, I was building and running the fuzzer against recent (late June) Zephyr as recently as last week for the UUID PR. Will take a look. Nothing's changed in the native-sim code recently that I've noticed.

@andyross
Copy link
Contributor

andyross commented Jul 3, 2024

Ah, it was this patch, merged last Tuesday: zephyrproject-rtos/zephyr@6e977ae

Seems not unreasonable to have broken something in native-sim, especially since both the host libc and sanitizer code may well demand that their own constructors run before entry to the OS kernel they're instrumenting. Honestly don't know how this was working before, @aescolar is the author of both and might have a better guess than me.

FWIW: simply reverting that is enough to recover the SOF fuzzer. I'll see if there's a more kconfig-ish workaround available before trying to dig in to see what the changes were.

andyross added a commit to andyross/zephyr that referenced this pull request Jul 3, 2024
Unfortunately this breaks native_sim fuzzing due (presumably) to
interactions with the .ctors emitted by the libc/sanitizer layer.

See SOF discussion at thesofproject/sof#9278

This reverts commit 6e977ae.

Signed-off-by: Andy Ross <andyross@google.com>
@aescolar
Copy link

aescolar commented Jul 3, 2024

Ah, it was this patch, merged last Tuesday: zephyrproject-rtos/zephyr@6e977ae

Apologies for that regression.
As mentioned in zephyrproject-rtos/zephyr#75399 you should be able to switch your target to native_sim (from native_posix) and it should work,
or a fix for the issue itself is queued here: zephyrproject-rtos/zephyr#75404

Copy link
Collaborator

@marc-hb marc-hb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both MTL https://sof-ci.01.org/sofpr/PR9278/build6183/devicetest/index.html
and LNL and LNL https://sof-ci.01.org/sofpr/PR9278/build6182/devicetest/index.html are 100% green!

CAVS25 is 100% green except for 1 model missing.

I recommend we don't block this on the other, unrelated sparse and fuzzer fixes which are already submitted and successfully tested elsewhere.

@marc-hb marc-hb added bug Something isn't working as expected P1 Blocker bugs or important features labels Jul 3, 2024
Copy link
Member

@plbossart plbossart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should merge this to unlock CI tests, for now we only have failures on MTL and LNL

@kv2019i
Copy link
Collaborator Author

kv2019i commented Jul 4, 2024

Let's proceed with this and solve the fuzzer issue (thanks for quick reaction @andyross !) in a follow-up PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected P1 Blocker bugs or important features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants