-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[STABLE-v2.2] Update rimage to version 02abc5d342a3, including critical openssl3 fix #9342
Conversation
Fixes thesofproject#9340 This adds the following commits from the main rimage branch: ``` commit 02abc5d ("rimage: ace signing functions need openssl 3.0 guards") commit 73a9d7c ("rimage: fix openssl 3.0 support in ver25 signing") commit 8ba3d17 ("adsp_config: fix name parsing error in parse_signed_pkg_ace_v1_5") commit fe4dcaa ("mtl: Add ASRC module to the manifest") commit af947cb ("config: Add toml config for mtl") commit c484d99 ("rimage: add ACE V1.5 handling") commit 1b233f6 ("config: add rmb toml file to support rembrandt build") ``` This is the smallest main branch fast-forward that includes the critical openssl3 fix commit 73a9d7c ("rimage: fix openssl 3.0 support in ver25 signing") _and_ compiles. This happens to align the rimage version in stable-v2.2 to the version in stable-v2.3. stable-v2.3 is not in use anymore but it was routinely tested in CI for a long time. In fact this stable-v2.2 commit is the same as stable-v2.3 commit 4e1d3ba ("rimage: update to version 02abc5d") Signed-off-by: Marc Herbert <marc.herbert@intel.com>
stable-2.2 should not have any support for ACE and MTL, I am confused here? |
Indeed not: here I'm trying NOT to create a new rimage branch and avoid cherry-picks to keep things simple. So this is just the smallest possible fast-forward on the old rimage main branch. This happens to pick up a couple irrelevant and harmless commits along the way. |
ah ok, i thought those were cherry-picked. Thanks for the explanation. |
The test result is promising. FW download success and HDA/DP playback and DMIC record also work. => current stable-v2.2 => after patched: |
Fixes #9340
This adds the following commits from the main rimage branch:
This is the smallest main branch fast-forward that includes the critical openssl3 fix commit 73a9d7c ("rimage: fix openssl 3.0 support in ver25 signing") and compiles.
This happens to align the rimage version in stable-v2.2 to the version in stable-v2.3. stable-v2.3 is not in use anymore but it was routinely tested in CI for a long time. In fact this stable-v2.2 commit is the same as stable-v2.3 commit 4e1d3ba ("rimage: update to version 02abc5d")