Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xtensa/config/core.h: provide UINT32_C() not just for __ZEPHYR__ #9442

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

marc-hb
Copy link
Collaborator

@marc-hb marc-hb commented Sep 5, 2024

xt-clang uses UINT32_C() without importing it. Commit ef38a0c ("arch: xtensa: core.h: Add define for UINT32_C") added it but only for __ZEPHYR__, add it unconditionally.

Provide an alternative, assembly-compatible definition apparently needed by XTOS ACP 7.0 compiled with xt-clang.

For C code, simply include <stdint.h>

Longer and convoluted story in #9413.

xt-clang uses UINT32_C() without importing it.  Commit ef38a0c
("arch: xtensa: core.h: Add define for UINT32_C") added it but only for
__ZEPHYR__, add it unconditionally.

Provide an alternative, assembly-compatible definition apparently needed
by XTOS ACP 7.0 compiled with xt-clang.

For C code, simply include <stdint.h>

Longer and convoluted story in thesofproject#9413.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Copy link
Contributor

@andyross andyross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed this seems cleaner

@saisurya-ch saisurya-ch self-requested a review September 5, 2024 17:57
@marc-hb
Copy link
Collaborator Author

marc-hb commented Sep 5, 2024

Unrelated suspend/resume failure in https://sof-ci.01.org/sofpr/PR9442/build7703/devicetest/index.html

Usual LNL failures in https://sof-ci.01.org/sofpr/PR9442/build7701/devicetest/index.html

Everything else green.

@kv2019i kv2019i merged commit 46f0eea into thesofproject:main Sep 6, 2024
45 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants