Topology2: add topologies for SDCA functions #9668
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a preparation commit for splitting topologies by devices. That means we will have generic hda topologies without HDMI. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
lgirdwood
reviewed
Nov 21, 2024
bardliao
changed the title
|
CI test result #47819 looks good. |
ranj063
reviewed
Nov 27, 2024
| @@ -110,6 +110,30 @@ SDW_JACK_OUT_STREAM=Playback-SimpleJack,SDW_JACK_IN_STREAM=Capture-SimpleJack" | |||
| SDW_AMP_FEEDBACK=false,SDW_SPK_STREAM=Playback-SmartAmp,SDW_DMIC_STREAM=Capture-SmartMic,\ | |||
| SDW_JACK_OUT_STREAM=Playback-SimpleJack,SDW_JACK_IN_STREAM=Capture-SimpleJack" | |||
|
|
|||
| #SDCA multi-function | |||
There was a problem hiding this comment.
@bardliao 2 questions:
- WHy is the BE ID important in the topology name?
- Why do you need to make HDMI optional based on the number of HDMI's in sof-hda-generic in the first patch when that you never modify NUM_HDMI for any of the HDMI topologies?
There was a problem hiding this comment.
@bardliao 2 questions:
- WHy is the BE ID important in the topology name?
The BE id in the topology should match the BE id exposed by the machine driver.
And BE id could be different between devices. For example, HDMI BE ids depends on how many SDW links are created and is PCH DMIC link is created.
- Why do you need to make HDMI optional based on the number of HDMI's in sof-hda-generic in the first patch when that you never modify NUM_HDMI for any of the HDMI topologies?
I would like to split the sof-hda-generic topology in the end. So, we need to make HDMI optional and remove the HDMI part from the generic sof-hda-generic topologies.
Add topologies for each sdca function. Linux kernel will load the corresponding topology per sdca function. The naming rule is sof-<platform>-<function>-<BE id> Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
bardliao
force-pushed
the
topology2-sdca
branch
from
a738b49 to
4a1aae6
Compare
|
@ranj063 good for you ? |
|
Let's wait for the kernel PR thesofproject/linux#5209 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add topologies for each sdca function. Linux kernel will load the corresponding topology per sdca function. The naming rule is sof---