Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: enable RTC_AEC module for LNL and PTL platforms #9730

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tmleman
Copy link
Contributor

@tmleman tmleman commented Dec 17, 2024

This patch enables the Google Real Time Communication Audio Processing (RTC_AEC) module for the LNL (Lunar Lake) and PTL (Panther Lake) platforms. The RTC_AEC module is essential for performing echo-cancelling and other real-time audio processing tasks.

Changes include:

  • Enabling CONFIG_COMP_GOOGLE_RTC_AUDIO_PROCESSING and CONFIG_GOOGLE_RTC_AUDIO_PROCESSING_MOCK in the intel_adsp_ace20_lnl.conf configuration file.
  • Enabling CONFIG_COMP_GOOGLE_RTC_AUDIO_PROCESSING and CONFIG_GOOGLE_RTC_AUDIO_PROCESSING_MOCK in the intel_adsp_ace30_ptl.conf configuration file.

This change ensures that the RTC_AEC module is included in the firmware builds for these platforms, allowing for proper testing and functionality of real-time audio processing features.

This patch enables the Google Real Time Communication Audio Processing
(RTC_AEC) module for the LNL (Lunar Lake) and PTL (Panther Lake)
platforms. The RTC_AEC module is essential for performing
echo-cancelling and other real-time audio processing tasks.

Changes include:
- Enabling CONFIG_COMP_GOOGLE_RTC_AUDIO_PROCESSING and
  CONFIG_GOOGLE_RTC_AUDIO_PROCESSING_MOCK in the intel_adsp_ace20_lnl.conf
  configuration file.
- Enabling CONFIG_COMP_GOOGLE_RTC_AUDIO_PROCESSING and
  CONFIG_GOOGLE_RTC_AUDIO_PROCESSING_MOCK in the intel_adsp_ace30_ptl.conf
  configuration file.

This change ensures that the RTC_AEC module is included in the firmware
builds for these platforms, allowing for proper testing and
functionality of real-time audio processing features.

Signed-off-by: Tomasz Leman <tomasz.m.leman@intel.com>
Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lyakh could we make all the mocks into modules and then load then into CI via UUID ?

@lyakh
Copy link
Collaborator

lyakh commented Dec 19, 2024

@lyakh could we make all the mocks into modules and then load then into CI via UUID ?

@lgirdwood sure, but we'd need topologies that include those stub components to load and test them

@marcinszkudlinski
Copy link
Contributor

marcinszkudlinski commented Dec 19, 2024

@tmleman please compile AEC as a LLEXT loadable module, we don't need it in production.
@lyakh @lgirdwood MOCK is an integral part of AEC in case of testing and will be loaded together with AEC

EDIT: it may also require changes in testing, a module has to be loaded

@lyakh
Copy link
Collaborator

lyakh commented Dec 20, 2024

@tmleman please compile AEC as a LLEXT loadable module, we don't need it in production. @lyakh @lgirdwood MOCK is an integral part of AEC in case of testing and will be loaded together with AEC

EDIT: it may also require changes in testing, a module has to be loaded

@marcinszkudlinski so it is run-time tested in QB?

@marcinszkudlinski
Copy link
Contributor

@tmleman please compile AEC as a LLEXT loadable module, we don't need it in production. @lyakh @lgirdwood MOCK is an integral part of AEC in case of testing and will be loaded together with AEC
EDIT: it may also require changes in testing, a module has to be loaded

@marcinszkudlinski so it is run-time tested in QB?

test for AEC + Mock is included in internal CI tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants