[stable-v2.12] rimage: fix resource leak #9743
Conversation
Ensure null termination in man_module_create_reloc Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
Fix resource leak in man_module_create_reloc Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
abonislawski
requested review from
lgirdwood,
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
|
@abonislawski Can we merge to main first and then backport with a "cherry-picked xxx) entry? We still have time until January, so I'd prefer to have all changes go through main. |
This needs to be today. |
|
Let's go with direct PR here then. @abonislawski please submit to main still on the side. |
| @@ -512,6 +512,8 @@ static int man_module_create_reloc(struct image *image, struct manifest_module * | |||
| unsigned int j; | |||
|
|
|||
| strncpy(name, (char *)sof_mod->module.name, SOF_MAN_MOD_NAME_LEN); | |||
There was a problem hiding this comment.
This would be a further update if needed, I think we are good to go today with @abonislawski fix.
| @@ -512,6 +512,8 @@ static int man_module_create_reloc(struct image *image, struct manifest_module * | |||
| unsigned int j; | |||
|
|
|||
| strncpy(name, (char *)sof_mod->module.name, SOF_MAN_MOD_NAME_LEN); | |||
There was a problem hiding this comment.
This would be a further update if needed, I think we are good to go today with @abonislawski fix.
Main branch PR: #9747 |
|
MTL failure unrelated. Looks like IGK DUT config. |
No description provided.