refactor: refactor in memory transaction mngr proxy & transaction mnr…

… interface (#48)
thetribeio · Nov 16, 2023 · 7a77a1b · 7a77a1b
1 parent f57616e
commit 7a77a1b
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 15 deletions.
diff --git a/src/configuration/injection/containers/database.ts b/src/configuration/injection/containers/database.ts
@@ -11,7 +11,7 @@ const useAppDataSources = (): void => {
     const AppDataSource = new DataSource({
         type: "postgres",
         synchronize: true,
-        logging: true,
+        logging: false,
         entities: ['src/driven/repositories/typeorm/entities/*.{ts,js}'],
         subscribers: [],
         migrations: ['src/driven/repositories/typeorm/migrations/*.{ts,js}'],

diff --git a/src/core/domain/common/interfaces/transactionManager.ts b/src/core/domain/common/interfaces/transactionManager.ts
@@ -1,5 +1,3 @@
-import TransactionInterface from './transaction';
-
 /**
  * Interface to manage commits and rollbacks within the system's core.
  *
@@ -11,12 +9,6 @@ export default interface TransactionManagerInterface {
      */
     startTransaction(): Promise<void>;
 
-    /**
-     * Creates and returns a new transaction
-     * that can be used to commit without the need of the method startTransaction().
-     */
-    newTransaction(): TransactionInterface;
-
     /**
      * Commits a change of state in the system.
      */

diff --git a/src/driven/repositories/inMemory/common/transactions/manager.ts b/src/driven/repositories/inMemory/common/transactions/manager.ts
@@ -12,7 +12,8 @@ export default class InMemoryTransactionManager {
     }
 
     /**
-     * Returns a new in memory transaction.
+     * Creates and returns a new transaction
+     * that can be used to commit without the need of the method startTransaction().
      */
     newTransaction(): InMemoryTransaction {
         return new InMemoryTransaction(this.unitOfWork);

diff --git a/tests/unit/car/query/retrieveCarsPlanning/retrieveCarsPlanning.test.ts b/tests/unit/car/query/retrieveCarsPlanning/retrieveCarsPlanning.test.ts
@@ -24,6 +24,7 @@ import PermissionsDenyStubGateway from "tests/common/stubs/gateways/permissions/
 import {buildExpectedCarsPlanning} from "tests/unit/car/query/retrieveCarsPlanning/beforeEach";
 import {buildCarTestCases} from "tests/unit/car/query/retrieveCarsPlanning/each";
 import UserPermissionsProfile from "src/core/useCases/common/permissions/types/userPermissionsProfile";
+import InMemoryTransactionManager from "src/driven/repositories/inMemory/common/transactions/manager";
 
 describe.each([
     {
@@ -324,7 +325,7 @@ describe.each([
 
         beforeEach(async () => {
             useInMemoryRepositories();
-            const transactionManager: TransactionManagerInterface = container.resolve("TransactionManagerInterface");
+            const transactionManager: InMemoryTransactionManager = container.resolve("TransactionManagerInterface");
             const transaction: TransactionInterface = transactionManager.newTransaction();
             const unitOfWork: UnitOfWork = container.resolve("UnitOfWork");
             await populateCarModel({
@@ -494,7 +495,7 @@ describe.each([
 
         beforeEach(async () => {
             useInMemoryRepositories();
-            const transactionManager: TransactionManagerInterface = container.resolve("TransactionManagerInterface");
+            const transactionManager: InMemoryTransactionManager = container.resolve("TransactionManagerInterface");
             const transaction: TransactionInterface = transactionManager.newTransaction();
             const unitOfWork: UnitOfWork = container.resolve("UnitOfWork");
             await populateCarModel({

diff --git a/tests/unit/carRental/command/rentACar.test.ts b/tests/unit/carRental/command/rentACar.test.ts
@@ -18,6 +18,7 @@ import InMemoryCarRentalReadRepository from 'src/driven/repositories/inMemory/ca
 import TransactionInterface from 'src/core/domain/common/interfaces/transaction';
 import TransactionManagerInterface from 'src/core/domain/common/interfaces/transactionManager';
 import UnavailableCarError from 'src/core/domain/car/errors/unavailable';
+import InMemoryTransactionManager from "src/driven/repositories/inMemory/common/transactions/manager";
 
 describe.each([
     {
@@ -129,7 +130,7 @@ describe.each([
 
     beforeEach(async () => {
         useInMemoryRepositories();
-        const transactionManager: TransactionManagerInterface = container.resolve("TransactionManagerInterface");
+        const transactionManager: InMemoryTransactionManager = container.resolve("TransactionManagerInterface");
         const transaction: TransactionInterface = transactionManager.newTransaction();
         await populateCarsAndCarRentalsFromTestCase(testCase.cars);
         await populateAvailableCarFromTestCase(testCase.availableCar as CarTestCaseEntry);
@@ -215,7 +216,7 @@ describe.each([
 
     beforeEach(async () => {
         useInMemoryRepositories();
-        const transactionManager: TransactionManagerInterface = container.resolve("TransactionManagerInterface");
+        const transactionManager: InMemoryTransactionManager = container.resolve("TransactionManagerInterface");
         const transaction: TransactionInterface = transactionManager.newTransaction();
         await populateAvailableCarFromTestCase(testCase.availableCar as CarTestCaseEntry);
         await transaction.commit();

diff --git a/tests/unit/carRental/query/retrieveACarRental.test.ts b/tests/unit/carRental/query/retrieveACarRental.test.ts
@@ -13,6 +13,7 @@ import RetrieveACarRentalQuery from 'src/core/useCases/carRental/query/retrieveA
 import {populateCarModel, populateCarRental} from '../../utils/populate';
 import UnitOfWork from 'src/driven/repositories/inMemory/common/unitOfWork';
 import InMemoryCarRentalReadRepository from 'src/driven/repositories/inMemory/carRental/read';
+import InMemoryTransactionManager from "src/driven/repositories/inMemory/common/transactions/manager";
 
 describe.each([
     {
@@ -76,7 +77,7 @@ describe.each([
     beforeEach(async () => {
         useInMemoryRepositories();
         const unitOfWork: UnitOfWork = container.resolve("UnitOfWork");
-        const transactionManager: TransactionManagerInterface = container.resolve("TransactionManagerInterface");
+        const transactionManager: InMemoryTransactionManager = container.resolve("TransactionManagerInterface");
         const transaction: TransactionInterface = transactionManager.newTransaction();
         const totalPrice = convertToNumericPrice(testCase.carRental.totalPrice);
         await populateCarRental({