Disable WDS contentBase option #282
Conversation
We setup express static middleware ourselves so the content base option is not needed.
| @@ -77,6 +77,7 @@ async function start() { | |||
|
|
|||
| // webpack dev server (with HMR) | |||
| const devServer = new WebpackDevServer(clientCompiler, { | |||
| contentBase: false, | |||
There was a problem hiding this comment.
Maybe add a comment here to explain why ? And link the issue which forced this change
There was a problem hiding this comment.
The issue is juste the trigger for the change, but the option should be disable even if the bug wasn't present.
Currently the whole project directory is served by the server (for example you can go to http://localhost:3000/package.json to get the package.json file).
Another solution would be to remove the static middleware in the before option and instead configure the contentBase option to serve the public directory.
There was a problem hiding this comment.
The alternative would be #287
There was a problem hiding this comment.
The alternative seems fine to me, the lesser behaviors we have to do ourselves, the better.
We setup express static middleware ourselves so the content base option is not needed.
This will fix sending POST request to the API until the related bug is fixed in webpack-dev-server.