add readyState constants to browser w3cwebsocket
#282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the exposed `w3cwebsocket` export mirrors the native WebSocket more closely. I hit this bug when moving previously native code to use this wrapper, the server-sde code was fine, but the client-side code failed because `WebSocket.OPEN` was `undefined`.
theturtle32
approved these changes
Oct 18, 2017
|
NOTE: The WebSocket API does not define Anyhow, it's ok to support them since it seems that previous (draft?) versions of the spec did define them and some JS libs/apps still rely on them. |
|
@ibc - I already merged this, perhaps too hastily, but does this make sense to you? |
|
@ibc - Do you think this should stay? |
Yes, as argued in my latest comment :) |
|
ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the exposed
w3cwebsocketexport mirrors the native WebSocket more closely.I hit this bug when moving previously native code to use this wrapper, the server-sde code was fine,
but the client-side code failed because
WebSocket.OPENwasundefined.