Patch for https://github.com/theturtle32/WebSocket-Node/issues/288 #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pretty sure this same thing is happening to me. It would be nice to get the fix in there @theturtle32 |
|
Confirmed this patch works for me! |
theturtle32
approved these changes
Oct 18, 2017
|
npm 1.0.25, please? :) |
|
We really should revamp the handling of connection closing, I think, but until then yeah I will try to get this out in the next day or so. |
|
So many thanks. |
|
Published v1.0.25 |
|
When my server ran with version 1.0.24, sometimes it got loop and did not accept any new connections. Does that relate to this problem and can be fixed by version 1.0.25? |
|
@quanguyen that looks exactly that: the bug fixed in 1.0.25. Just upgrade. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mitigate infinite loop for broken connections.
#288