Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect URLs for next/previous URLs #109

Closed
IanMayo opened this issue Jul 18, 2023 · 0 comments · Fixed by #110
Closed

Incorrect URLs for next/previous URLs #109

IanMayo opened this issue Jul 18, 2023 · 0 comments · Fixed by #110
Assignees

Comments

@IanMayo
Copy link
Collaborator

IanMayo commented Jul 18, 2023

The end of a Soul data slug includes the total number of matching rows, plus URLS for next and previous pages:

,"total":28, "next":"/tables/invoices?page=3","previous":"/tables/invoices?page=1"

These URLs are missing the rows element. The page element should also have an underscore.

So, next should be /tables/invoices/rows?_page=3

Hmm, I think the strategy for the URL is also mistaken. If the requests includes fields, filters, sort, etc, then the URL provided won't provide the next page of relevant results. It will just return the next page from the whole table.

So, I think that _next and _previous should contain all of the request URL parameters (except for _page - since a new value for that is being generated in the new URL).

@AbegaM AbegaM self-assigned this Jul 18, 2023
@thevahidal thevahidal linked a pull request Jul 20, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants