Add support for filter operators #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @thevahidal Please review this PR and let me know if there is anything i have to improve |
IanMayo
reviewed
Jul 17, 2023
core/src/controllers/rows.js
Outdated
| @@ -66,15 +75,23 @@ const listTableRows = async (req, res) => { | |||
| // will filter by name like '%John%' and age like '%20%' | |||
|
|
|||
| const filters = _filters.split(',').map((filter) => { | |||
| const [field, value] = filter.split(':'); | |||
| return { field, value }; | |||
| let [key, value] = filter.split(':'); | |||
There was a problem hiding this comment.
I'd like this to be more pessimistic, please @AbegaM . I'd like us to handle when a filter doesn't match our expected list, and throw a suitable error message.
There was a problem hiding this comment.
@IanMayo Ah, I haven't considered that. I will modify the code to throw errors.
There was a problem hiding this comment.
@thevahidal, I have added error handling to the feature request. Please review it and let me know if there is anything I can modify.
|
Thanks for the effort guys, it looks good to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #105
Purpose of PR
The purpose of this PR is to enhance the filtering feature of
Soul. Currently, the_filtersfield is used for basic filtering, but it does not allow users to filter items by comparing them or by using comparison operators.Modifications
To address this limitation, I have made modifications to the
rows.jsfile in thecore/src/controllersdirectory. With these changes, users can now filter items using comparison operators such as__lte,__gte,__lt,__gt,__eq, and__neq. With this improved filtering functionality, users can more effectively search and analyze data in the Soul application.