Deprecate transaction endpoint #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thevahidal
force-pushed
the
deprecate-transaction-endpoint
branch
2 times, most recently
from
703b9a4 to
e019c33
Compare
thevahidal
force-pushed
the
deprecate-transaction-endpoint
branch
from
e019c33 to
c3a6760
Compare
IanMayo
approved these changes
Jun 3, 2024
AbegaM
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in issue #172, the
/api/transactionendpoint presents a security risk and doesn't align with Soul's philosophy of user-friendly, human-readable APIs accessible to non-SQL users.Initially, this endpoint served as a tribute to the ws4sqlite library that inspired Soul's development. While I envisioned it as potentially useful, particularly with the introduction of authentication, it's become clear that the transaction endpoint is no longer a viable option. Therefore, I've decided to remove it.