Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user confirmation before uninstalling #101

Merged
merged 1 commit into from
Oct 30, 2021

Conversation

bacali95
Copy link
Collaborator

closes #71

@bacali95 bacali95 requested a review from thevpc October 30, 2021 16:45
@bacali95 bacali95 self-assigned this Oct 30, 2021
@thevpc
Copy link
Owner

thevpc commented Oct 30, 2021

Can you call

getSession().getTerminal().ask()

instead of

getSession().term().getTerminal().ask()

the latter is fo using global terminal, the first is the terminal associated to the session itself.

@bacali95 bacali95 force-pushed the fix/add-confirmation-before-uninstall branch from 3248a54 to b333343 Compare October 30, 2021 17:35
@bacali95
Copy link
Collaborator Author

Can you call

getSession().getTerminal().ask()

instead of

getSession().term().getTerminal().ask()

the latter is fo using global terminal, the first is the terminal associated to the session itself.

Done.

@thevpc thevpc merged commit 1e62675 into master Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

uninstall should required confirmation
2 participants