Add QualificationResult to WCIF spec #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given here for discussion - I think in creating the `qualification_data` endpoint we've created a new WCA data object which should be specified. Just a suggestion at this stage - everything (naming, existence, properties) is open to discussion. (Maybe this doesn't belong here at all, because we don't return QualificationResults in the WCIF?) ((Also sorry this is not coming in from my fork, I edited directly in the gh editor and want to stay in flow))
|
I think the WCIF documentation should only include types that are a part of WCIF itself, otherwise it can be confusing for readers :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given here for discussion - I think in creating the
qualification_dataendpoint we've created a new WCA data object which should be specified.Just a suggestion at this stage - everything (naming, existence, properties) is open to discussion.
(Maybe this doesn't belong here at all, because we don't return QualificationResults in the WCIF?)
((Also sorry this is not coming in from my fork, I edited directly in the gh editor and want to stay in flow))