Gremlin Base Functionality

[whichsteveyp]

[Edited by @aseemk: see previous discussion at issue #44.]

Hey guys,

So I believe I finished a basic, working support of the Gremlin plugin for this module. I did not update the documentation, README, or module version as I know there are other features in the works that pertain to all of those.

Included some starter tests that seem to indicate it is working, I'm sure further testing and usage will prove otherwise but I'll keep working on it. My next steps are to see if transactional & multi-line gremlin work as intended with it as well.

Let me know if you need anything else on this though!

Usage: db.execute(script, optional: params, callback)
Test: npm run gremlin

[aseemk]

Awesome stuff! I'll take a look in depth, and we can hopefully release this, sometime this week!

[aseemk]

Hey good news, it turns out my transform code didn't handle paths properly, and in the process of fixing that I went ahead and made it recurse maps too:

0551fb2

So now you shouldn't need any special-case for Gremlin results. But let me know if you still do.

(You can rebase your branch onto the latest develop to test.)

[whichsteveyp]

Awesome. Yea, I need to get a bit more thorough with the tests I have after looking at some of yours for the cypher ones with the transform function, I'll see if I can figure out this "rebase" magic you mention, get the update worked in and tested, and get it pushed back up to ya.

[aseemk]

Try this:

# start at your latest commit
$ git checkout develop

# create a pointer to this commit as-is for backup
$ git branch backup

# assuming the remote for this thingdom repo is called upstream, fetch the latest
$ git fetch upstream

# now rebase your develop onto the latest thingdom develop
$ git rebase upstream/develop

# hopefully no conflicts. but if there are, just follow the instructions:
# - fix the conflicts, e.g. using git mergetool
# - then git rebase --continue

# if a seeming-conflict arises but there are no changed files:
# - git rebase --skip

# if at any point things are totally fubar:
# - git rebase --abort

# now if you do a git log, you should see your changes cleanly on top of the ones here
$ git log --graph --decorate --pretty=oneline --abbrev-commit

# then update your github repo (which'll update this pull request)
# assuming you call that remote origin
$ git push origin develop -f

A helpful reference:
http://git-scm.com/book/en/Git-Branching-Rebasing

And for future reference, you might prefer to do this kind of work in a feature (AKA topic) branch instead of in develop. That way you can always easily keep your develop in sync with the upstream develop, and then it's just a simple rebase of your topic branch onto your own develop.

Hope this helps!

[whichsteveyp]

Thanks for the rebase tips and resources, that was a first. I like the idea of using topic branches and utilizing that in future projects though - awesome stuff.

This commit passed the tests I have already written: whichsteveyp@318d68e

[aseemk]

Sorry for the delay here, but finally getting to this, and it looks great! I'm just doing a bit of cleanup -- I'll leave comments here for future reference, but don't worry, I'm already taking care of them.

Thanks again @sprjr!

[aseemk]

There is no official gremlin endpoint baked in, so simplifying this to only check the plugin endpoint.

[aseemk]

Merged! Thanks and great work again @sprjr. =) I'll post here when this gets published to npm.

[aseemk]

Okay, published as 0.2.17! Woot!