Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled to set the thift frame size for astyanax. #1146

Open
wants to merge 1 commit into
base: titan05
Choose a base branch
from

Conversation

deiflaender
Copy link

No description provided.

@dalaro dalaro self-assigned this Sep 16, 2015
@dalaro
Copy link
Member

dalaro commented Sep 16, 2015

Thanks for this. I'm not sure whether to apply it on titan05, but I did just commit something similar to titan09: 1001f3a. I unified the option for frame size between the cassandrathrift and astyanax backends, and I went up to the latest current astyanax version 3.8.0. Is there a reason the PR specifically chose 3.6.0 instead?

@deiflaender
Copy link
Author

Hi, it would be nice to have this in titan0.5, because
cassandrathrift-backend(obsolete now?) does not reconnect to cassandra
cluster if connections get lost.
The reason why i took 3.6.0, was only that 3.8.0 was not available as i
implemented this on our local branch(has some more minor fixes, pull
requests comming soon...)

On Wed, Sep 16, 2015 at 6:19 PM, Dan LaRocque notifications@github.com
wrote:

Thanks for this. I'm not sure whether to apply it on titan05, but I did
just commit something similar to titan09: 1001f3a
1001f3a.
I unified the option for frame size between the cassandrathrift and
astyanax backends, and I went up to the latest current astyanax version
3.8.0. Is there a reason the PR specifically chose 3.6.0 instead?


Reply to this email directly or view it on GitHub
#1146 (comment).

@dalaro
Copy link
Member

dalaro commented Sep 17, 2015

I suppose we can defend the version upgrade on the grounds that it enables functionality crucial for accessing some datasets with Astyanax. I'll look at applying this to titan05 as well. For backwards compatibility on titan05, I will retain your option layout (a pair of duplicate frame-size options, one for astyanax and one for thrift).

@dalaro dalaro added this to the Titan0.5.5 milestone Sep 21, 2015
@concretevitamin
Copy link

@deiflaender just curious, are those "minor fixes" in your local branch related to Thrift frame size / Titan-Cassandra connection issues?

@deiflaender
Copy link
Author

No

On Wed, Sep 23, 2015 at 2:44 AM, Zongheng Yang notifications@github.com
wrote:

@deiflaender https://github.com/deiflaender just curious, are those
"minor fixes" in your local branch related to Thrift frame size /
Titan-Cassandra connection issues?


Reply to this email directly or view it on GitHub
#1146 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants