T5281 - Port CC Token #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkst-pieter
requested changes
Mar 29, 2023
thinkst-pieter
approved these changes
Mar 30, 2023
wleightond
added a commit
that referenced
this pull request
May 31, 2023
wleightond
added a commit
that referenced
this pull request
Jul 18, 2023
wleightond
added a commit
that referenced
this pull request
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports the CC token to v3. This is a synthesis of the original python3 implementation and the current python2 one which had additional changes.
Note, non-live instances will fail to generate tokens unless CANARY_DOMAINS is set with an actual domain name, as Extend blocks token URLS with domain
127.0.0.1. In addition, since the token fire is a callback, triggering a token via a transaction will not work unless the instance is live.Todo: