Mixed fixes - from mh's and blake's feedbacks #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wording 'how to deploy, make required fields
mclmax
approved these changes
Jul 3, 2024
| id: string; | ||
| label: string; | ||
| arrowVariant?: 'one' | 'two'; | ||
| arrowWordPosition?: number; |
There was a problem hiding this comment.
heh, this component is very cute
to over-engineer this even further you could even see this being an array (not really feedback)
There was a problem hiding this comment.
don't tempt me...!
Comment on lines
27
to
31
| <!--- CTA text ---> | ||
| <div | ||
| class="w-full leading-5 font-semibold border-t-2 border-grey-50 text-grey-700 h-[3rem] rounded-b-xl transition duration-100 hover-card shadow-solid-shadow-grey card-button justify-center items-center flex px-8" | ||
| class="w-full leading-5 font-semibold border-t-2 border-grey-50 text-grey-700 h-[3rem] rounded-b-2xl transition duration-100 hover-card shadow-solid-shadow-grey card-button justify-center items-center flex px-8" | ||
| > | ||
| {{ isHoverCard ? 'Create Token' : title }} |
There was a problem hiding this comment.
i guess this is just github parsing this file weirdly?
There was a problem hiding this comment.
uhm what's weird about it?
mclmax
pushed a commit
that referenced
this pull request
Jul 16, 2024
* Add base label, add required label, fix searchbar icon position, fix wording 'how to deploy, make required fields * make stuff rounder * Revert Canarytoken setting title, center radio input * fix padding on required * add label arrow, fix tests * remove focus from selected card
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Home Page
Fix tooltip for Cards
Fix border radius
Remove focus after clicking on modal
Searchbar: reposition icon
Fix page paddings
Remove icons from navbar
Remove 'document' from token's labels
Modal Add Token
Fix Notification inputs by adding custom arrows
Remove 'Notification settings' title
Fix border radius
Add 'required field' hint
Fix required fields for all form that needed it
Minor tweaks
Increment border radius of most elements
Fix some alignments
Fix some wording/typos
Components
Add a new BaseLabel component + tests
Add a new BaseLabelArrow components + tests
Fix tests for BaseInput