Add a proper XML header to error replies. (cs3org#1828)

thmour · Jul 12, 2021 · 5588d9a · 5588d9a
1 parent af6b700
commit 5588d9a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/changelog/unreleased/xmlheadertoerrors.md b/changelog/unreleased/xmlheadertoerrors.md
@@ -0,0 +1,3 @@
+Bugfix: send a proper XML header with error messages 
+
+https://github.com/cs3org/reva/pull/1828
diff --git a/internal/http/services/owncloud/ocdav/error.go b/internal/http/services/owncloud/ocdav/error.go
@@ -58,13 +58,17 @@ type exception struct {
 
 // Marshal just calls the xml marshaller for a given exception.
 func Marshal(e exception) ([]byte, error) {
-	return xml.Marshal(&errorXML{
+	xmlstring, err := xml.Marshal(&errorXML{
 		Xmlnsd:    "DAV",
 		Xmlnss:    "http://sabredav.org/ns",
 		Exception: codesEnum[e.code],
 		Message:   e.message,
 		Header:    e.header,
 	})
+	if err != nil {
+		return []byte(""), err
+	}
+	return []byte(xml.Header + string(xmlstring)), err
 }
 
 // http://www.webdav.org/specs/rfc4918.html#ELEMENT_error