Revert "set the name more properly to help Janko (#1106)" #1118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 782291b.
|
This was breaking for Oscar, so let's wait with this change till we do the next breaking release. |
|
It needs a doc fix in Oscar after...
…On Sun, 11 Jun 2023, 16:26 Tommy Hofmann, ***@***.***> wrote:
This was breaking for Oscar, so let's wait with this change till we do the
next breaking release.
—
Reply to this email directly, view it on GitHub
<#1118 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA36CV7WZRFR3Q7W36SOD5DXKXIRRANCNFSM6AAAAAAZCL25UU>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1118 +/- ##
==========================================
+ Coverage 69.33% 69.43% +0.10%
==========================================
Files 349 349
Lines 112925 113011 +86
==========================================
+ Hits 78298 78474 +176
+ Misses 34627 34537 -90
☔ View full report in Codecov by Sentry. |
|
I need a quick release, so I revert this for now (but will reapply it). |
thofma
added a commit
that referenced
this pull request
Jul 3, 2023
thofma
added a commit
that referenced
this pull request
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 782291b.