Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous matrix methods #1138

Merged
merged 5 commits into from
Jul 1, 2023
Merged

Miscellaneous matrix methods #1138

merged 5 commits into from
Jul 1, 2023

Conversation

mgkurtz
Copy link
Contributor

@mgkurtz mgkurtz commented Jun 26, 2023

The call to hnf(A) gives a row echelon form, but no information about rank or pivots. These fast methods provide that information. (Without verifying the echelon form.)

Also fix the transpose! method, I have lately introduced.

@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Patch coverage: 89.47% and no project coverage change.

Comparison is base (75eb599) 69.41% compared to head (618da5a) 69.42%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1138   +/-   ##
=======================================
  Coverage   69.41%   69.42%           
=======================================
  Files         349      349           
  Lines      113011   113036   +25     
=======================================
+ Hits        78444    78471   +27     
+ Misses      34567    34565    -2     
Impacted Files Coverage Δ
src/Misc/Matrix.jl 70.74% <89.47%> (+0.33%) ⬆️

... and 40 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@thofma
Copy link
Owner

thofma commented Jun 27, 2023

Good idea to not export them, but then the doctests need the module prefix.

@thofma thofma merged commit 1ce2a45 into thofma:master Jul 1, 2023
12 of 16 checks passed
@thofma
Copy link
Owner

thofma commented Jul 1, 2023

Thanks!

I am not too big of the cond || bla syntax. It is a bit hard to parse at a first glance (for errors it is fine, since it is usually clear what is checked). I will merge this as is, but maybe we can avoid it in the future.

lgoettgens added a commit to lgoettgens/Nemo.jl that referenced this pull request Jul 2, 2023
lgoettgens added a commit to lgoettgens/Nemo.jl that referenced this pull request Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants