Replace == nothing by === nothing

[lgoettgens]

No description provided.

[thofma]

What is the reason for this change? The binary version is much more readable and with === replaced by == faster than isnothing (across all julia version >= 1.6).

[fieker]

On Tue, Jun 27, 2023 at 08:47:58AM -0700, Lars Göttgens wrote: You can view, comment on, or merge this pull request online at: #1141 -- Commit Summary -- * Replace `== nothing` by `isnothing`

Why? Is this better readable? To me: no Is this faster? Don't know

…

-- File Changes -- M examples/FieldEnumeration/abelian_extensions.jl (4) M examples/FieldEnumeration/all_fields.jl (6) M examples/MultDep.jl (2) M src/AlgAssAbsOrd/Conjugacy/Conjugacy.jl (2) M src/AlgAssAbsOrd/NEQ.jl (2) M src/EllCrv/Periods.jl (4) M src/Grp/Morphisms.jl (16) M src/GrpAb/GrpAbFinGen.jl (2) M src/GrpAb/Lattice.jl (6) M src/Misc/Integer.jl (4) M src/NumField/NfAbs/MPolyGcd.jl (22) M src/NumField/NfAbs/NormRelation/SUnits.jl (2) M src/NumFieldOrd/NfOrd/Clgp.jl (6) M src/NumFieldOrd/NfOrd/Clgp/Main_LLL.jl (2) M src/NumFieldOrd/NfOrd/Clgp/Map.jl (2) M src/NumFieldOrd/NfOrd/Clgp/Sunits.jl (2) M src/QuadForm/Quad/ZLattices.jl (6) M src/QuadForm/Torsion.jl (4) M test/Map/NumberField.jl (2) M test/NfAbs/NfAbs.jl (2) M test/testdefs.jl (2) -- Patch Links -- https://github.com/thofma/Hecke.jl/pull/1141.patch https://github.com/thofma/Hecke.jl/pull/1141.diff -- Reply to this email directly or view it on GitHub: #1141 You are receiving this because you are subscribed to this thread. Message ID: ***@***.***>

[lgoettgens]

Comparing against nothing with ===/!== instead of ==/!= is a recommended change by the Julia linter in VSCode.

Sorry for the isnothing stuff in the first version of this. Using === nothing and isnothing seems to be a personal style of code, and it wasn't my intention to debate that here.

[thofma]

Thanks for the adjustment. (https://docs.julialang.org/en/v1.6/manual/performance-tips/#Checking-for-equality-with-a-singleton is the reference for the === nothing vs isnothing difference on some older julia versions, which we still support).

[codecov]

Codecov Report

Patch coverage: 73.91% and project coverage change: -0.13 ⚠️

Comparison is base (e0986b7) 69.51% compared to head (215c044) 69.38%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1141      +/-   ##
==========================================
- Coverage   69.51%   69.38%   -0.13%     
==========================================
  Files         349      349              
  Lines      113018   113018              
==========================================
- Hits        78562    78416     -146     
- Misses      34456    34602     +146     

Impacted Files	Coverage Δ
src/AlgAssAbsOrd/NEQ.jl	0.00% <0.00%> (ø)
src/Grp/Morphisms.jl	78.57% <0.00%> (ø)
src/GrpAb/GrpAbFinGen.jl	73.89% <0.00%> (-0.10%)	⬇️
src/NumField/NfAbs/MPolyGcd.jl	68.83% <0.00%> (ø)
src/QuadForm/Quad/ZLattices.jl	92.78% <50.00%> (-0.74%)	⬇️
src/AlgAssAbsOrd/Conjugacy/Conjugacy.jl	98.32% <100.00%> (ø)
src/EllCrv/Periods.jl	93.47% <100.00%> (ø)
src/GrpAb/Lattice.jl	84.78% <100.00%> (ø)
src/Misc/Integer.jl	50.78% <100.00%> (ø)
src/NumField/NfAbs/NormRelation/SUnits.jl	64.59% <100.00%> (ø)
... and 5 more

... and 30 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.