Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overflow bug in C2xC2 field computation #1148

Merged
merged 1 commit into from
Jul 3, 2023
Merged

Fix overflow bug in C2xC2 field computation #1148

merged 1 commit into from
Jul 3, 2023

Conversation

thofma
Copy link
Owner

@thofma thofma commented Jul 3, 2023

No description provided.

@thofma
Copy link
Owner Author

thofma commented Jul 3, 2023

Bug appears with bound ~10^12, so a bit hard to add a test.

@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: +0.16 🎉

Comparison is base (de95733) 69.29% compared to head (4af83b0) 69.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1148      +/-   ##
==========================================
+ Coverage   69.29%   69.46%   +0.16%     
==========================================
  Files         349      349              
  Lines      113013   113018       +5     
==========================================
+ Hits        78318    78510     +192     
+ Misses      34695    34508     -187     
Impacted Files Coverage Δ
src/FieldFactory/ab_exts.jl 57.15% <66.66%> (-0.23%) ⬇️

... and 46 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@thofma thofma merged commit f6d58a6 into master Jul 3, 2023
13 of 16 checks passed
@thofma thofma deleted the th/fixfix branch July 3, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant