Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ordering -> internal_ordering #1402

Merged
merged 3 commits into from
Feb 20, 2024
Merged

ordering -> internal_ordering #1402

merged 3 commits into from
Feb 20, 2024

Conversation

joschmitt
Copy link
Collaborator

@joschmitt joschmitt commented Feb 14, 2024 •
edited
Loading

@joschmitt joschmitt mentioned this pull request Feb 15, 2024
Merged
@joschmitt joschmitt closed this Feb 20, 2024
@joschmitt joschmitt reopened this Feb 20, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Merging #1402 (49af779) into master (77b2fdf) will decrease coverage by 0.10%.
The diff coverage is 60.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1402      +/-   ##
==========================================
- Coverage   70.73%   70.63%   -0.10%     
==========================================
  Files         350      350              
  Lines      111877   111877              
==========================================
- Hits        79132    79022     -110     
- Misses      32745    32855     +110
Files Coverage Δ
src/NumFieldOrd/NfOrd/MaxOrd/MaxOrd.jl 74.27% <100.00%> (-4.89%) ⬇️
src/NumField/NfAbs/MPolyAbsFact.jl 69.44% <33.33%> (-0.31%) ⬇️

... and 33 files with indirect coverage changes

@thofma thofma merged commit d2620fb into thofma:master Feb 20, 2024
18 checks passed
@joschmitt joschmitt deleted the js/ordering branch February 20, 2024 15:20
fieker pushed a commit that referenced this pull request Apr 2, 2024
@joschmitt @fieker
ordering -> internal_ordering (#1402)
b94987c 
* `ordering` -> `internal_ordering`

* Bump AbstractAlgebra and Nemo

* Adjust to `kernel` methods being removed in AbstractAlgebra
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joschmitt @thofma