Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bring algebras into shape #1588

Merged
merged 1 commit into from
Sep 7, 2024
Merged

feat: bring algebras into shape #1588

merged 1 commit into from
Sep 7, 2024

Conversation

thofma
Copy link
Owner

@thofma thofma commented Aug 29, 2024

  • documentation
  • tests
  • renaming

@thofma thofma force-pushed the th/sca branch 2 times, most recently from 7f234c5 to 2b704c9 Compare August 29, 2024 09:17
@thofma thofma closed this Aug 29, 2024
@thofma thofma reopened this Aug 29, 2024
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 91.23649% with 73 lines in your changes missing coverage. Please review.

Project coverage is 75.70%. Comparing base (ee980a7) to head (ee36582).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
src/AlgAss/Conversions.jl 82.03% 67 Missing ⚠️
src/AlgAss/AbsAlgAss.jl 72.72% 3 Missing ⚠️
src/AlgAss/Decompose.jl 99.33% 2 Missing ⚠️
src/AlgAss/StructureConstantAlgebra.jl 99.20% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1588       +/-   ##
===========================================
+ Coverage    5.44%   75.70%   +70.26%     
===========================================
  Files         358      362        +4     
  Lines      113490   113899      +409     
===========================================
+ Hits         6183    86231    +80048     
+ Misses     107307    27668    -79639     
Files with missing lines Coverage Δ
src/AlgAss/AlgGrp.jl 72.89% <100.00%> (+72.89%) ⬆️
src/AlgAss/AlgMat.jl 88.54% <100.00%> (+88.54%) ⬆️
src/AlgAss/Elem.jl 88.68% <100.00%> (+88.68%) ⬆️
src/AlgAssAbsOrd/Elem.jl 84.51% <100.00%> (+84.51%) ⬆️
src/AlgAssAbsOrd/Ideal.jl 77.04% <100.00%> (+77.04%) ⬆️
src/AlgAss/StructureConstantAlgebra.jl 93.44% <99.20%> (ø)
src/AlgAss/Decompose.jl 99.33% <99.33%> (ø)
src/AlgAss/AbsAlgAss.jl 88.05% <72.72%> (+88.05%) ⬆️
src/AlgAss/Conversions.jl 82.03% <82.03%> (ø)

... and 317 files with indirect coverage changes

@thofma thofma force-pushed the th/sca branch 4 times, most recently from 18b1257 to e5d966f Compare September 1, 2024 19:29
@thofma thofma marked this pull request as ready for review September 1, 2024 19:30
@thofma thofma force-pushed the th/sca branch 2 times, most recently from 4967344 to 1d4b078 Compare September 7, 2024 08:21
- documentation
- tests
- renaming
@thofma thofma merged commit faab4d6 into master Sep 7, 2024
18 checks passed
@thofma thofma deleted the th/sca branch September 7, 2024 15:34
This was referenced Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant