Make compatible with new AA and Nemo #1613
Conversation
|
Does the error message mean we have to use |
|
Yes, I seemed to forgot one of them when I tackled the rest. Already fixed in |
|
I try to keep the history clean here, so you could maybe merge this with a merge commit, such that the cherry-picked other PRs stay separately in history. |
lgoettgens
force-pushed
the
lg/Nemo-AA-compat
branch
from
ce43b46
to
c7425f2
Compare
lgoettgens
force-pushed
the
lg/Nemo-AA-compat
branch
2 times, most recently
from
c837862
to
470e13e
Compare
|
needed: Nemocas/Nemo.jl#1856 |
|
Where exactly? I am not a big fan of this |
|
has another factor(::Int) call.The following error is thrown in . You can try to adapt that function if you want. I'll wait until you either approve Nemocas/Nemo.jl#1856 or push a fix here (but watch out as I force-pushed this branch in the last hour or so). |
lgoettgens
force-pushed
the
lg/Nemo-AA-compat
branch
from
becdc43
to
c0dbc77
Compare
and some further related fixes
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1613 +/- ##
==========================================
- Coverage 75.95% 75.79% -0.17%
==========================================
Files 362 361 -1
Lines 113698 113700 +2
==========================================
- Hits 86364 86179 -185
- Misses 27334 27521 +187
|
|
Test pass!!! 🎉 🎉 |
I cherry-pick the changes from all other fixing branches here to see if CI is happy.
Progress:
addeq!changes #1612padic_field/qadic_fieldand prepare deprecations #1604assertions.jlnow moved to AA #1607coefficient_ring->base_fieldfor the p-adics #1605Thus closes #1611, closes #1612, closes #1604, closes #1607, closes #1605.
I try to keep the history clean here, so you could maybe merge this with a merge commit, such that the cherry-picked other PRs stay separately in history.