Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add components method to Abelian group #1632

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/src/manual/abelian/elements.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ parent(x::FinGenAbGroupElem)
### Access

```@docs
components(x::FinGenAbGroupElem)
getindex(x::FinGenAbGroupElem, i::Int)
```

Expand Down
9 changes: 9 additions & 0 deletions src/GrpAb/Elem.jl
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,15 @@
#
################################################################################

@doc raw"""
components(x::FinGenAbGroupElem) -> Vector{ZZRingElem}

Returns the components of the element $x$.
"""
function components(x::FinGenAbGroupElem)
return x.coeff

Check warning on line 146 in src/GrpAb/Elem.jl

View check run for this annotation

Codecov / codecov/patch

src/GrpAb/Elem.jl#L145-L146

Added lines #L145 - L146 were not covered by tests
end

@doc raw"""
getindex(x::FinGenAbGroupElem, i::Int) -> ZZRingElem

Expand Down
1 change: 1 addition & 0 deletions src/exports.jl
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,7 @@ export codifferent
export codomain
export coefficient_ideals
export coefficients
export components
export coinvariant_lattice
export cokernel
export collapse_top_layer
Expand Down
Loading