Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The big renaming #977

Merged
merged 5 commits into from
Feb 24, 2023
Merged

The big renaming #977

merged 5 commits into from
Feb 24, 2023

Conversation

fingolfin
Copy link
Contributor

@fingolfin fingolfin commented Feb 22, 2023

@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Base: 74.11% // Head: 74.13% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (1d651c4) compared to base (8ba02f2).
Patch coverage: 73.28% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #977      +/-   ##
==========================================
+ Coverage   74.11%   74.13%   +0.02%     
==========================================
  Files         347      347              
  Lines      110707   110707              
==========================================
+ Hits        82048    82072      +24     
+ Misses      28659    28635      -24     
Impacted Files Coverage Δ
src/AlgAss/Ideal.jl 77.71% <0.00%> (ø)
src/AlgAss/Types.jl 86.36% <0.00%> (ø)
src/AlgAssAbsOrd/Conjugacy/Random.jl 0.00% <0.00%> (ø)
src/AlgAssAbsOrd/Eichler.jl 0.00% <0.00%> (ø)
src/AlgAssRelOrd/NEQ.jl 40.37% <0.00%> (ø)
src/Deprecations.jl 4.54% <0.00%> (ø)
src/FieldFactory/non_normal.jl 0.00% <0.00%> (ø)
src/GrpAb/Lattice.jl 86.23% <ø> (ø)
src/LargeField/basis.jl 0.00% <0.00%> (ø)
src/LargeField/misc2.jl 0.00% <0.00%> (ø)
... and 261 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fingolfin fingolfin marked this pull request as ready for review February 24, 2023 07:54
@fingolfin
Copy link
Contributor Author

@thofma @fieker ready

@fieker fieker merged commit 22d78b5 into thofma:master Feb 24, 2023
@fingolfin fingolfin deleted the mh/rename branch February 24, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants