Add SyncTeX support #31
Conversation
|
Just wanted to chime in real quick and say that this looks really promising! Will play around with it tonight or tomorrow. Thanks! |
This should make sure that each "project" stores its PDF file name persistently across sessions, while allowing for several projects (unlike the previous solution).
Untested methods as of this commit include: * latex.sync * latex.getConfigFilePath * latex.setOutputFilePath * latex.getOutputFilePath
|
Bump. I'm not sure why the build fails, but it doesn't look like it's in the test I added. |
| @@ -112,3 +127,28 @@ module.exports = | |||
| destroyErrorIndicator: -> | |||
| @errorIndicator?.destroy() | |||
| @errorIndicator = null | |||
|
|
|||
| getConfigFilePath: -> | |||
| filePath = path.join(atom.getConfigDirPath(), latex.cson) | |||
There was a problem hiding this comment.
You've forgotten to quote the filename. This line should be
filePath = path.join(atom.getConfigDirPath(), 'latex.cson')
|
Testing this now. The specs are passing once the unquoted string is fixed. I'm not entirely comfortable with the config bits you've added. I want to rely on the log files for determining the output files. It should be sufficient for the time being. I plan on making the code around log parsing more robust in the very near future, and part of this will be extending the result path parsing aspect a little bit further. Also, is there any specific reason we need both an |
|
The config bits mostly ensure that the file name is remembered across sessions, but if that's not a requirement they could probably be removed. Unifying the (Note: I won't be able to work on this PR for the next week or so, I have a thesis presentation coming up.) |
|
If you want, I can apply your changes to a branch of my own and rework them a little, then have you give it a thumbs up or down? You'll retain full credit for all your efforts of course (I'll rewrite the commit history a little bit though). P.S. Good luck on your thesis presentation! |
|
That works for me :) |
|
Haven't had much time to finish the adjustments, but you can track the progress on https://github.com/thomasjo/atom-latex/tree/pull-31. Completely flooded with reports and what not right now, but I might have time to finish it tonight. |
|
Finally got around to finalizing the tweaks, and merging this. Just published v0.14.0. Thanks for helping out, and thanks for your patience! |
This pull request should add SyncTeX support for the Skim opener, with keymap
ctrl-alt-s(syncing on current line).Probably these things need to be looked at before merging: