Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(website): fix openfeature_python.md documentation #2733

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

CMiksche
Copy link
Contributor

In new versions of the OpenFeature SDK there are no names but domains

See open-feature/python-sdk@ed6a42f

Checklist

  • I have updated the documentation (README.md and /website/docs)
  • I have followed the contributing guide

In new versions of the OpenFeature SDK there are no names but domains
Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for go-feature-flag-doc-preview ready!

Name Link
🔨 Latest commit e6260ba
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/674782599064100008c71355
😎 Deploy Preview https://deploy-preview-2733--go-feature-flag-doc-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.84%. Comparing base (f33383a) to head (e6260ba).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2733   +/-   ##
=======================================
  Coverage   84.84%   84.84%           
=======================================
  Files         111      111           
  Lines        5167     5167           
=======================================
  Hits         4384     4384           
  Misses        620      620           
  Partials      163      163           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@thomaspoignant thomaspoignant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good catch, I forgot to update the doc when the SDK changed.

Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
@thomaspoignant thomaspoignant merged commit 2dcea82 into thomaspoignant:main Nov 27, 2024
15 checks passed
Copy link

sonarcloud bot commented Nov 27, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants