fix(exporter): Ensure that timestamp are in second and not milliseconds #2751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for go-feature-flag-doc-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
thomaspoignant
force-pushed
the
fix-timestamp-ms
branch
from
5d42b6c to
0c3d2be
Compare
| // but since it is totally possible to have a timestamp in seconds that is bigger than 9999999999 | ||
| // we will accept timestamp up to 9999999999 (2286-11-20 18:46:39 +0100 CET) | ||
| event.CreationDate, _ = strconv.ParseInt( | ||
| strconv.FormatInt(event.CreationDate, 10)[:10], 10, 64) |
There was a problem hiding this comment.
logging some warning would help resolve such issues in the clients. At least it would be visible.
There was a problem hiding this comment.
Yes you are right, let me add a WARN log.
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2751 +/- ##
==========================================
+ Coverage 84.84% 84.87% +0.03%
==========================================
Files 111 111
Lines 5167 5178 +11
==========================================
+ Hits 4384 4395 +11
Misses 620 620
Partials 163 163 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
thomaspoignant
force-pushed
the
fix-timestamp-ms
branch
from
c8d492c to
8986f97
Compare
|
augustinasrce
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is adding a conversion check on the feature event date to be sure that what we receive is in seconds not in milliseconds.
Checklist