-
-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Use timeout middleware as the 1st middleware #2759
Conversation
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
✅ Deploy Preview for go-feature-flag-doc-preview canceled.
|
@natenho I'll be happy to get your review for this one. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2759 +/- ##
==========================================
- Coverage 84.87% 84.83% -0.05%
==========================================
Files 111 111
Lines 5178 5184 +6
==========================================
+ Hits 4395 4398 +3
- Misses 620 623 +3
Partials 163 163 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Quality Gate passedIssues Measures |
Description
Use timeout middleware as the 1st middleware as mentioned here.
It should help when dealing concurrency writing the headers.
@natenho please tell me if you reproduce the bug with the next version.
Closes issue(s)
Resolve #2758
Checklist