Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use timeout middleware as the 1st middleware #2759

Merged
merged 5 commits into from
Dec 9, 2024
Merged

Conversation

thomaspoignant
Copy link
Owner

@thomaspoignant thomaspoignant commented Dec 6, 2024

Description

Use timeout middleware as the 1st middleware as mentioned here.
It should help when dealing concurrency writing the headers.

@natenho please tell me if you reproduce the bug with the next version.

Closes issue(s)

Resolve #2758

Checklist

Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Copy link

netlify bot commented Dec 6, 2024

Deploy Preview for go-feature-flag-doc-preview canceled.

Name Link
🔨 Latest commit 6a30a84
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/6756f51549c857000806f8c8

@thomaspoignant
Copy link
Owner Author

@natenho I'll be happy to get your review for this one.

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 84.83%. Comparing base (c1eb753) to head (6a30a84).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/relayproxy/api/server.go 75.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2759      +/-   ##
==========================================
- Coverage   84.87%   84.83%   -0.05%     
==========================================
  Files         111      111              
  Lines        5178     5184       +6     
==========================================
+ Hits         4395     4398       +3     
- Misses        620      623       +3     
  Partials      163      163              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Copy link

sonarcloud bot commented Dec 9, 2024

@thomaspoignant thomaspoignant merged commit 2f5be32 into main Dec 9, 2024
22 of 24 checks passed
@thomaspoignant thomaspoignant deleted the fix-2758 branch December 9, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(bug) Panic concurrent map writes
1 participant