Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(timeout): Fix the swagger issue introduce after fixing #2758 #2794

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

thomaspoignant
Copy link
Owner

@thomaspoignant thomaspoignant commented Dec 13, 2024

Description

When trying to fix #2758 we have introduced an issue that makes swagger not working anymore.

Closes issue(s)

Resolve #2758

Checklist

Copy link

netlify bot commented Dec 13, 2024

Deploy Preview for go-feature-flag-doc-preview canceled.

Name Link
🔨 Latest commit 491023c
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/675c77b5f8310e000886068f

Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
@thomaspoignant thomaspoignant force-pushed the fix-timeout-swagger-issue branch from 5716293 to 491023c Compare December 13, 2024 18:06
Copy link

sonarcloud bot commented Dec 13, 2024

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.78%. Comparing base (e81df19) to head (491023c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2794   +/-   ##
=======================================
  Coverage   84.77%   84.78%           
=======================================
  Files         111      111           
  Lines        5190     5191    +1     
=======================================
+ Hits         4400     4401    +1     
  Misses        626      626           
  Partials      164      164           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kodiakhq kodiakhq bot merged commit 8ae0c6d into main Dec 13, 2024
23 checks passed
@kodiakhq kodiakhq bot deleted the fix-timeout-swagger-issue branch December 13, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(bug) Panic concurrent map writes
1 participant