Upgrade EUI to 12.1.0 (elastic#39601)

* eui@12.1.0 * jest regenerator-runtime babel-polyfill * TS Toast -> EuiGlobalToastListToast * EuiBadge * EuiCopy * snapshot updates * simplify toast interface usage * misc review cleanup * remove eui core-js resolution
thompsongl · Jun 26, 2019 · 13070b1 · 13070b1
1 parent 475e0b2
commit 13070b1
Show file tree

Hide file tree

Showing 56 changed files with 191 additions and 185 deletions.
diff --git a/package.json b/package.json
@@ -79,8 +79,7 @@
   "resolutions": {
     "**/@types/node": "10.12.27",
     "**/@types/hapi": "^17.0.18",
-    "**/typescript": "^3.3.3333",
-    "**/@elastic/eui/**/core-js": "2.6.9"
+    "**/typescript": "^3.3.3333"
   },
   "workspaces": {
     "packages": [
@@ -104,7 +103,7 @@
     "@babel/register": "7.4.4",
     "@elastic/charts": "^6.0.1",
     "@elastic/datemath": "5.0.2",
-    "@elastic/eui": "11.3.2",
+    "@elastic/eui": "12.1.0",
     "@elastic/filesaver": "1.1.2",
     "@elastic/good": "8.1.1-kibana2",
     "@elastic/numeral": "2.3.3",

diff --git a/src/core/public/notifications/toasts/global_toast_list.tsx b/src/core/public/notifications/toasts/global_toast_list.tsx
@@ -17,7 +17,7 @@
  * under the License.
  */
 
-import { EuiGlobalToastList, Toast } from '@elastic/eui';
+import { EuiGlobalToastList, EuiGlobalToastListToast as Toast } from '@elastic/eui';
 
 import React from 'react';
 import * as Rx from 'rxjs';

diff --git a/src/core/public/notifications/toasts/index.ts b/src/core/public/notifications/toasts/index.ts
@@ -19,4 +19,4 @@
 
 export { ToastsService, ToastsSetup, ToastsStart } from './toasts_service';
 export { ErrorToastOptions, ToastsApi, ToastInput } from './toasts_api';
-export { Toast } from '@elastic/eui';
+export { EuiGlobalToastListToast as Toast } from '@elastic/eui';
diff --git a/src/core/public/notifications/toasts/toasts_api.tsx b/src/core/public/notifications/toasts/toasts_api.tsx
@@ -17,7 +17,7 @@
  * under the License.
  */
 
-import { Toast } from '@elastic/eui';
+import { EuiGlobalToastListToast as Toast } from '@elastic/eui';
 import React from 'react';
 import * as Rx from 'rxjs';
 

diff --git a/src/core/public/notifications/toasts/toasts_service.tsx b/src/core/public/notifications/toasts/toasts_service.tsx
@@ -20,7 +20,7 @@
 import React from 'react';
 import { render, unmountComponentAtNode } from 'react-dom';
 
-import { Toast } from '@elastic/eui';
+import { EuiGlobalToastListToast as Toast } from '@elastic/eui';
 import { I18nStart } from '../../i18n';
 import { UiSettingsSetup } from '../../ui_settings';
 import { GlobalToastList } from './global_toast_list';

diff --git a/src/core/public/public.api.md b/src/core/public/public.api.md
@@ -8,7 +8,7 @@ import { IconType } from '@elastic/eui';
 import { Observable } from 'rxjs';
 import React from 'react';
 import * as Rx from 'rxjs';
-import { Toast } from '@elastic/eui';
+import { EuiGlobalToastListToast as Toast } from '@elastic/eui';
 
 // @public (undocumented)
 export interface ApplicationSetup {

diff --git a/src/dev/jest/setup/babel_polyfill.js b/src/dev/jest/setup/babel_polyfill.js
@@ -21,3 +21,5 @@
 // include the necessary polyfills when using `@babel/preset-env`, but for some
 // reason it did not work. See https://github.com/elastic/kibana/issues/14506
 import '../../../setup_node_env/babel_register/polyfill';
+// Required for EUI
+import 'regenerator-runtime/runtime';
diff --git a/src/legacy/core_plugins/data/public/filter/filter_bar/filter_view/index.tsx b/src/legacy/core_plugins/data/public/filter/filter_bar/filter_view/index.tsx
@@ -28,7 +28,7 @@ interface Props {
   [propName: string]: any;
 }
 
-export const FilterView: SFC<Props> = ({ filter, ...rest }: Props) => {
+export const FilterView: SFC<Props> = ({ filter, iconOnClick, onClick, ...rest }: Props) => {
   let title = `Filter: ${getFilterDisplayText(filter)}. ${i18n.translate(
     'data.filter.filterBar.moreFilterActionsMessage',
     {
@@ -51,16 +51,17 @@ export const FilterView: SFC<Props> = ({ filter, ...rest }: Props) => {
     <EuiBadge
       title={title}
       iconType="cross"
-      // @ts-ignore
       iconSide="right"
       closeButtonProps={{
         // Removing tab focus on close button because the same option can be optained through the context menu
         // Also, we may want to add a `DEL` keyboard press functionality
-        tabIndex: '-1',
+        tabIndex: -1,
       }}
+      iconOnClick={iconOnClick}
       iconOnClickAriaLabel={i18n.translate('data.filter.filterBar.filterItemBadgeIconAriaLabel', {
         defaultMessage: 'Delete',
       })}
+      onClick={onClick}
       onClickAriaLabel={i18n.translate('data.filter.filterBar.filterItemBadgeAriaLabel', {
         defaultMessage: 'Filter actions',
       })}

diff --git a/...re_plugins/kibana/public/home/components/tutorial/__snapshots__/introduction.test.js.snap b/...re_plugins/kibana/public/home/components/tutorial/__snapshots__/introduction.test.js.snap
diff --git a/.../create_index_pattern_wizard/components/header/__jest__/__snapshots__/header.test.js.snap b/.../create_index_pattern_wizard/components/header/__jest__/__snapshots__/header.test.js.snap
diff --git a/...egacy/core_plugins/status_page/public/components/__snapshots__/server_status.test.js.snap b/...egacy/core_plugins/status_page/public/components/__snapshots__/server_status.test.js.snap
diff --git a/...y/ui/public/field_editor/components/scripting_help/__snapshots__/help_flyout.test.js.snap b/...y/ui/public/field_editor/components/scripting_help/__snapshots__/help_flyout.test.js.snap
diff --git a/src/legacy/ui/public/share/components/__snapshots__/url_panel_content.test.js.snap b/src/legacy/ui/public/share/components/__snapshots__/url_panel_content.test.js.snap
diff --git a/src/legacy/ui/public/share/components/url_panel_content.tsx b/src/legacy/ui/public/share/components/url_panel_content.tsx
@@ -100,7 +100,10 @@ class UrlPanelContentUI extends Component<Props, State> {
 
         {this.renderShortUrlSwitch()}
 
-        <EuiCopy textToCopy={this.state.url} anchorClassName="kbnShareContextMenu__copyAnchor">
+        <EuiCopy
+          textToCopy={this.state.url || ''}
+          anchorClassName="kbnShareContextMenu__copyAnchor"
+        >
           {(copy: () => void) => (
             <EuiButton
               fill

diff --git a/test/interpreter_functional/plugins/kbn_tp_run_pipeline/package.json b/test/interpreter_functional/plugins/kbn_tp_run_pipeline/package.json
@@ -7,7 +7,7 @@
   },
   "license": "Apache-2.0",
   "dependencies": {
-    "@elastic/eui": "11.3.2",
+    "@elastic/eui": "12.1.0",
     "react": "^16.8.0",
     "react-dom": "^16.8.0"
   }

diff --git a/test/plugin_functional/plugins/kbn_tp_custom_visualizations/package.json b/test/plugin_functional/plugins/kbn_tp_custom_visualizations/package.json
@@ -7,7 +7,7 @@
   },
   "license": "Apache-2.0",
   "dependencies": {
-    "@elastic/eui": "11.3.2",
+    "@elastic/eui": "12.1.0",
     "react": "^16.8.0"
   }
 }
diff --git a/test/plugin_functional/plugins/kbn_tp_embeddable_explorer/package.json b/test/plugin_functional/plugins/kbn_tp_embeddable_explorer/package.json
@@ -8,7 +8,7 @@
   },
   "license": "Apache-2.0",
   "dependencies": {
-    "@elastic/eui": "11.3.2",
+    "@elastic/eui": "12.1.0",
     "react": "^16.8.0"
   },
   "scripts": {

diff --git a/test/plugin_functional/plugins/kbn_tp_sample_panel_action/package.json b/test/plugin_functional/plugins/kbn_tp_sample_panel_action/package.json
@@ -8,7 +8,7 @@
   },
   "license": "Apache-2.0",
   "dependencies": {
-    "@elastic/eui": "11.3.2",
+    "@elastic/eui": "12.1.0",
     "react": "^16.8.0"
   },
   "scripts": {

diff --git a/test/plugin_functional/plugins/kbn_tp_visualize_embedding/package.json b/test/plugin_functional/plugins/kbn_tp_visualize_embedding/package.json
@@ -7,7 +7,7 @@
   },
   "license": "Apache-2.0",
   "dependencies": {
-    "@elastic/eui": "11.3.2",
+    "@elastic/eui": "12.1.0",
     "react": "^16.8.0",
     "react-dom": "^16.8.0"
   }

diff --git a/typings/@elastic/eui/index.d.ts b/typings/@elastic/eui/index.d.ts
@@ -22,7 +22,6 @@ import { Direction } from '@elastic/eui/src/services/sort/sort_direction';
 
 declare module '@elastic/eui' {
   export const EuiWrappingPopover: React.SFC<any>;
-  export const EuiCopy: React.SFC<any>;
   export const EuiOutsideClickDetector: React.SFC<any>;
   export const EuiSideNav: React.SFC<any>;
 

diff --git a/...m/public/components/app/ErrorGroupOverview/List/__test__/__snapshots__/List.test.tsx.snap b/...m/public/components/app/ErrorGroupOverview/List/__test__/__snapshots__/List.test.tsx.snap