Support concurrent CSRF cookies by using a prefix of nonce #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomseddon
requested changes
Sep 3, 2020
|
Hi, I am also experiencing this issue, if there any blocker to merge this PR ? |
|
Merged in #187 (with some a couple of extra tests) Thanks so much for this, and for the blog posts! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the problem of multiple login requests (with different nonces in state) rewriting the same CSRF cookie.
It provides a unique cookie per request by suffixing the CSRF cookie name with the first 6 characters of the nonce, e.g.
_forward_auth_csrf_986711.This should address #176 and #113
I've verified that it works in my local setup, and addresses the issue of using Traefik Forward Auth in front of single page apps such as Home Assistant.