Skip to content
This repository has been archived by the owner on Mar 3, 2020. It is now read-only.

Clear localStorage on reset #515

Merged
merged 1 commit into from
Apr 26, 2013
Merged

Clear localStorage on reset #515

merged 1 commit into from
Apr 26, 2013

Conversation

levicole
Copy link
Contributor

I think this should do it. Please let me know if there is a better way to do this.

@jferris
Copy link
Contributor

jferris commented Apr 26, 2013

I looked for a way to do this without evaluating JavaScript, but couldn't find a public API in Qt.

@mhoran any thoughts on this?

@mhoran
Copy link
Collaborator

mhoran commented Apr 26, 2013

I took a quick look as well and it doesn't look like there's a better way to do this. The only thing I'm not sure about is whether or not this clears local storage globally, or only entries pertaining to the current URL. Another option could be to disable local storage, delete the database and re-enable it.

@jferris
Copy link
Contributor

jferris commented Apr 26, 2013

Alright. What do you think about merging this for now, and we can write a spec/fix for cross-host storage if that comes up?

@mhoran
Copy link
Collaborator

mhoran commented Apr 26, 2013

Sounds good.

@jferris jferris merged commit 7bf3c80 into thoughtbot:master Apr 26, 2013
@jferris
Copy link
Contributor

jferris commented Apr 26, 2013

Thanks, @levicole. This is merged into master and will be included with the next release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants