Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

explicitly register helper, fixes #147 #148

Merged
merged 2 commits into from
Apr 14, 2015
Merged

explicitly register helper, fixes #147 #148

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
355371e
explicitly register helper, fixes #147
jesenko Apr 9, 2015
692418d
Call `helper` directly instead of using `send`
jesenko Apr 14, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/ember-cli/engine.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,11 @@ class Engine < Rails::Engine
initializer "ember-cli-rails.enable" do
EmberCLI.enable! unless EmberCLI.skip?
end

initializer "ember-cli-rails.helpers" do
config.to_prepare do
ActionController::Base.send :helper, EmberRailsHelper
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like helper is not a private method, so you don't need send here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, I have just committed a fix...

end
end
end
end