Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Ember Tests from Rails Engine #264

Merged
merged 1 commit into from
Nov 13, 2015
Merged

Remove Ember Tests from Rails Engine #264

merged 1 commit into from
Nov 13, 2015

Conversation

seanpdoyle
Copy link
Contributor

Remove support for viewing Ember tests through Rails.

Instead, use ember test or ember test --serve from within the Ember
directory.

@seanpdoyle
Remove Ember Tests from Rails Engine
a6a4cb4 
Remove support for viewing Ember tests through Rails.

Instead, use `ember test` or `ember test --serve` from within the Ember
directory.
@seanpdoyle seanpdoyle merged commit a6a4cb4 into master Nov 13, 2015
@seanpdoyle seanpdoyle deleted the sd-remove-test-support branch November 13, 2015 22:56
seanpdoyle added a commit that referenced this pull request Nov 14, 2015
@seanpdoyle
Delete EmberCli::Middleware
b283d3a 
Given that [each mounted Ember application manages its own `ember`
process][mount], and that Rails is [no longer responsible for running
EmberCLI tests][tests], the middleware no longer serves a purpose.

[mount]: #263
[tests]: #264
@seanpdoyle seanpdoyle mentioned this pull request Nov 14, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@seanpdoyle