Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance rake ember:install to fully reinstall if necessary. #396

Closed
wants to merge 7 commits into from
Closed

Enhance rake ember:install to fully reinstall if necessary. #396

wants to merge 7 commits into from

Commits on Feb 7, 2016

  1. Enhance rake ember:install to fully reinstall if necessary. 

    Ember CLI ships with ember-cli-dependency-checker, which provides the
`ember version` command, which is akin to `bundle check`. This commit enhances
the ember:install rake task to `rm -rf node_modules bower_components` before
installing if `ember version` returns non-zero. This (helped further by npm
shrinkwrap) works to ensure that every machine has the same dependencies.

Closes [thoughtbot#394].

[thoughtbot#394]: thoughtbot#394
    @botandrose-machine
    botandrose-machine committed Feb 7, 2016
    Configuration menu
    Copy the full SHA
    0038155 View commit details
    Browse the repository at this point in the history

  2. rename Shell#exec to Shell#run!.

    @botandrose-machine
    botandrose-machine committed Feb 7, 2016
    Configuration menu
    Copy the full SHA
    3b33348 View commit details
    Browse the repository at this point in the history

  3. extract Runner#run from Runner#run!.

    @botandrose-machine
    botandrose-machine committed Feb 7, 2016
    Configuration menu
    Copy the full SHA
    3c43e05 View commit details
    Browse the repository at this point in the history

  4. Rename npm and bower dep path accessors after their respective direct… 

    …ories.
    @botandrose-machine
    botandrose-machine committed Feb 7, 2016
    Configuration menu
    Copy the full SHA
    146960b View commit details
    Browse the repository at this point in the history

  5. Use new Runner#run method to make dependency checking cross-platform.

    @botandrose-machine
    botandrose-machine committed Feb 7, 2016
    Configuration menu
    Copy the full SHA
    61ec111 View commit details
    Browse the repository at this point in the history

  6. Don't complain if ember isn't yet installed during dependency check.

    @botandrose-machine
    botandrose-machine committed Feb 7, 2016
    Configuration menu
    Copy the full SHA
    5442451 View commit details
    Browse the repository at this point in the history

  7. Fix style issues.

    @botandrose-machine
    botandrose-machine committed Feb 7, 2016
    Configuration menu
    Copy the full SHA
    b6e12df View commit details
    Browse the repository at this point in the history