Commits on Aug 10, 2016

1. Add Rails 5 support …

   Closes [#376].
   
   Required changes
   ----------------
   
   Run test suite against the latest `5.0.0.betaX` and `master` branches of
   [`rails/rails`][rails].
   
   Since `EmberController` extends `ApplicationController`, which can now
   extend from either `ActionController::Base` (which implements
   `helper_method`) and `ActionController::API` (which doesn't implement
   `helper_method`), we can't depend on that API existing.
   
   Remove call to `helper_method` from `EmberController`, as it is no
   longer supported.
   
   **Allow JRuby failures in CI**
   
   **Improve `setup_ember` script**
   
   * Don't overwrite `gemfiles/` changes with `appraisal install`
   * Localize Ember setup to `bin/setup_ember`
   * Always invoke, let `bin/setup_ember` decide whether or not to no-op
   
   **Fix `EmberCli::EmberController` inheritance**
   
   The `EmberCli::EmberController` used to inherit from
   `ApplicationController` in order to reap the benefits of
   application-wide configurations and behavior (such as
   authentication-based `before_action` calls and other macros).
   
   Unfortunately, with the introduction of Rails 5's `rails new --api`,
   applications' `ApplicationController` can now inherit from
   [`ActionController::API`][api], which doesn't serve HTML by default.
   
   To support Rails 5's default `--api` behavior,
   `EmberCli::EmberController` must inherit from `ActionController::Base`,
   forcing the controller to forfeit all the benefits of sharing behavior
   with `ApplicationController`.
   
   [api]: http://edgeapi.rubyonrails.org/classes/ActionController/API.html
   
   **Depend on `test-unit`**
   
   ```
   Ruby 2.2+ has removed test/unit from the core library. Rails requires
   this as a dependency. Please add test-unit gem to your Gemfile:
   `gem 'test-unit', '~> 3.0'` (cannot load such file -- test/unit)"
   ```
   
   Support changes
   ---------------
   
   Rails 5 depends on `rack@2.0.x`, which **requires** Ruby `2.2.2` or
   greater.
   
   In order to support Rails 5, we will no longer support versions of Ruby
   prior to `2.2.2`.
   
   [#376]: #376
   [rails]: https://github.com/rails/rails

   

   seanpdoyle committed Aug 10, 2016
   Configuration menu

   • View commit details
   • Copy full SHA for 876720b
   • Browse repository at this point

   Copy the full SHA

   876720b View commit details

   Browse the repository at this point in the history