Configure EmberCli::Deploy::File cache headers
#403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpdoyle
force-pushed
the
cache-control-header
branch
2 times, most recently
from
ab3f0e6
to
e9e1399
Compare
| @@ -7,6 +7,8 @@ | |||
|
|
|||
| module Dummy | |||
| class Application < Rails::Application | |||
| CACHE_CONTROL_FIVE_MINUTES = "public, max-age=300" | |||
There was a problem hiding this comment.
Freeze mutable objects assigned to constants.
Closes [#401]. Previously, requests for Ember assets were being proxied through `EmberCli::Deploy::File` Rack middleware without the HTTP `Cache-Control` header. Ember `production` builds digest the filenames of images/css/js/etc. This makes these files highly cachable. This commit configures the underlying `Rack::File` middleware to serve assets with the `Cache-Control` header set by Rails. [#401]: #401
seanpdoyle
force-pushed
the
cache-control-header
branch
from
e9e1399
to
4c67d23
Compare
| @@ -7,6 +7,8 @@ | |||
|
|
|||
| module Dummy | |||
| class Application < Rails::Application | |||
| CACHE_CONTROL_FIVE_MINUTES = "public, max-age=300".freeze | |||
There was a problem hiding this comment.
Unfortunately, this workaround was required, as I couldn't get ClimateControl to override an ENV variable before this class was loaded.
|
finally got a chance to look at this... 👍 nice work! can't wait to test this out in the next release! |
|
Released in 0.7.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #401.
Previously, requests for Ember assets were being proxied through
EmberCli::Deploy::FileRack middleware without the HTTPCache-Controlheader.Ember
productionbuilds digest the filenames of images/css/js/etc.This makes these files highly cachable.
This commit configures the underlying
Rack::Filemiddleware to serveassets with the
Cache-Controlheader set by Rails.