This repository has been archived by the owner on Jul 14, 2023. It is now read-only.
Simplify grid-visual for consistent cross-browser behaviour #569
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gradient style of
grid-visual
behaves inconsistent across browsers and currently has major rendering issues on Chrome. In the same time having the gutters painted creates a bit of confusion, where I think users expect the paint to be applied to the columns. (mainly when coming from a design tool like Sketch or Illustrator where the grid layout highlights the columns and not the gutters).This mainly solves #539 but in the same time updates the
grid-visual
to a column-based painting rather than a gutter-based painting.We basically go from this:
to this:
This update simplifies the
grid-visual
mixin by introducing therepeating-linear-gradient(...)
property which allows us to consider the width of only a single column, instead of looping through each grid-column to create thelinear-gradient(...)
. Also thecalc()
function has better cross browser integration and consistency when used within therepeating-linear-gradient
property.