Skip to content
This repository has been archived by the owner on Jul 14, 2023. It is now read-only.

Fix AND operator in conditional #646

Merged
merged 1 commit into from
Mar 30, 2018

Conversation

mfeltscher
Copy link

This fixes the following Sass warning:

WARNING on line 107, column 40 of app/assets/stylesheets/grid/_omega.scss:
In Sass, "&&" means two copies of the parent selector. You probably want to use "and" instead.

@mfeltscher
Copy link
Author

@tysongach Any chance you could look into this and possibly release a new bugfix version for v1?

@tysongach
Copy link
Contributor

Pinging @whmii; he leads the Neat project.

@whmii
Copy link
Contributor

whmii commented Mar 29, 2018

Ill take a look at this first thing mañana. I have to double check the sass spec but if all looks good ill merge

@whmii
Copy link
Contributor

whmii commented Mar 30, 2018

@mfeltscher LGTM

@whmii whmii merged commit 73a0d04 into thoughtbot:v1-stable Mar 30, 2018
@mfeltscher
Copy link
Author

@whmii Thanks for merging! Are you going to release a new version which this fix is part of?

@mfeltscher mfeltscher deleted the fix/and-operator branch March 30, 2018 15:42
@mfeltscher
Copy link
Author

@whmii Any chance for 1.9.1? :)

@oliverlangan
Copy link

@whmii I'd also love to see a 1.9.1 with this fix, if you have a chance.

@DanieleGBX
Copy link

Bumping in support of that last comment.

@mfeltscher
Copy link
Author

@whmii Any news on this?

@whmii
Copy link
Contributor

whmii commented Jul 16, 2018

Currently it is unlikely this will get patched. Unfortunately the way NPM works, if we patch an older version it becomes the 'newest' in NPM www site which means that many users inadvertently download it expecting v2.0… or v3.0… which can cause major problems w/ people who do not specify their npm packages properly (which is like … a lot…).

🙇 While this is super inconvenient, If it continues to be an issue I whiled recommend creating a fork of Neat w/ these changes or switching over to 3.0 which has a bunch of awesome new features.

Sorry you are having these issues.

@DanieleGBX
Copy link

Couldn't the release be created right before a new 3.x version? That should work around the issue.

@Turbo87
Copy link

Turbo87 commented Sep 18, 2018

@whmii you can work around that by using the npm dist-tag command or using npm publish --tag v1.x for example

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants